1257936 - LeakCanary: (TabsPanel.mAddTab) BrowserApp has leaked 1.0MB

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: leak-report.txt

> * org.mozilla.gecko.BrowserApp has leaked:
> * GC ROOT static org.mozilla.gecko.tabs.TabsPanel.mAddTab
> * references android.widget.ImageButton.mContext
> * leaks org.mozilla.gecko.BrowserApp instance

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: device-2016-03-18-193050.png

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Static view references are definitely not right:
https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/tabs/TabsPanel.java#92-93

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: MozReview Request: Bug 1257936 - TabsPanel: Do not hold static references to views. r?ahunt

Review commit: https://reviewboard.mozilla.org/r/41093/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/41093/

Comment 4

[Andrzej Hunt :ahunt]

Comment on attachment 8732318 [details]
MozReview Request: Bug 1257936 - TabsPanel: Do not hold static references to views. r?ahunt

https://reviewboard.mozilla.org/r/41093/#review37713

WOW!

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

https://hg.mozilla.org/integration/fx-team/rev/ab15d48afbb2a88b157b305ff93384f5fe6398d0
Bug 1257936 - TabsPanel: Do not hold static references to views. r=ahunt

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ab15d48afbb2