Closed
Bug 1257936
Opened 8 years ago
Closed 8 years ago
LeakCanary: (TabsPanel.mAddTab) BrowserApp has leaked 1.0MB
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(firefox48 fixed)
RESOLVED
FIXED
Firefox 48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: sebastian, Assigned: sebastian)
References
Details
Attachments
(3 files)
> * org.mozilla.gecko.BrowserApp has leaked:
> * GC ROOT static org.mozilla.gecko.tabs.TabsPanel.mAddTab
> * references android.widget.ImageButton.mContext
> * leaks org.mozilla.gecko.BrowserApp instance
Assignee | ||
Comment 1•8 years ago
|
||
Assignee | ||
Comment 2•8 years ago
|
||
Static view references are definitely not right: https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/tabs/TabsPanel.java#92-93
Assignee | ||
Comment 3•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/41093/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/41093/
Attachment #8732318 -
Flags: review?(ahunt)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → s.kaspari
Status: NEW → ASSIGNED
Comment 4•8 years ago
|
||
Comment on attachment 8732318 [details] MozReview Request: Bug 1257936 - TabsPanel: Do not hold static references to views. r?ahunt https://reviewboard.mozilla.org/r/41093/#review37713 WOW!
Attachment #8732318 -
Flags: review?(ahunt) → review+
Assignee | ||
Comment 5•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/ab15d48afbb2a88b157b305ff93384f5fe6398d0 Bug 1257936 - TabsPanel: Do not hold static references to views. r=ahunt
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ab15d48afbb2
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•