mark the root of the rule tree during rule tree GC

RESOLVED WORKSFORME

Status

()

Core
CSS Parsing and Computation
RESOLVED WORKSFORME
2 years ago
2 years ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(firefox47 affected, firefox48 affected)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
I was just looking at some style system crashes, and one thing that occurred to me is that we should probably mark the root of the rule tree just in case there are (somehow!?) no style contexts.
(Assignee)

Comment 1

2 years ago
Created attachment 8732390 [details] [diff] [review]
Mark the root of the rule tree during rule tree GC

MozReview-Commit-ID: 1riBGYsGspn
Attachment #8732390 - Flags: review?(cam)
Attachment #8732390 - Flags: review?(cam) → review+
(Assignee)

Comment 2

2 years ago
So this was fixed on trunk by bug 1258017, but I'd still like to land it on aurora.  (Although the cause of the crashes we see is probably the other problems bholley fixed rather than this one, but it still seems worth trying.)
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → WORKSFORME
(Assignee)

Comment 3

2 years ago
Comment on attachment 8732390 [details] [diff] [review]
Mark the root of the rule tree during rule tree GC

Approval Request Comment
[Feature/regressing bug #]: not sure; pretty old
[User impact if declined]: potential crash
[Describe test coverage new/current, TreeHerder]: none
[Risks and why]: low risk; fixes one possible (although probably unlikely) source of crashes
[String/UUID change made/needed]: no
Attachment #8732390 - Flags: approval-mozilla-aurora?
(Assignee)

Comment 4

2 years ago
(Though probably we should just backport all of bug 1258017, and not bother with this.  But I should wait to see if Bobby, and release management, agrees...)

Updated

2 years ago
status-firefox47: --- → affected

Comment 5

2 years ago
I'll recheck again next week because of bug 1258017 comment 39. Will decide then whether we need both fixes or just one.

Comment 6

2 years ago
Hello DBaron, do we still need to uplift this fix? I already uplifted the patches from bug 1258017 in Aurora47.
Flags: needinfo?(dbaron)
(Assignee)

Comment 7

2 years ago
Comment on attachment 8732390 [details] [diff] [review]
Mark the root of the rule tree during rule tree GC

No need anymore.
Flags: needinfo?(dbaron)
Attachment #8732390 - Flags: approval-mozilla-aurora?

Comment 8

2 years ago
(In reply to David Baron [:dbaron] ⌚️UTC-7 (review requests must explain patch) from comment #7)
> Comment on attachment 8732390 [details] [diff] [review]
> Mark the root of the rule tree during rule tree GC
> 
> No need anymore.

Great! Thanks. :)
You need to log in before you can comment on or make changes to this bug.