Closed
Bug 1257983
Opened 8 years ago
Closed 8 years ago
Fix MANIFEST.in in external-media-tests package
Categories
(Testing Graveyard :: external-media-tests, defect)
Testing Graveyard
external-media-tests
Tracking
(firefox48 fixed)
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: impossibus, Assigned: ceridwen, Mentored)
Details
(Whiteboard: [good-first-bug][lang=py])
Attachments
(1 file)
The MANIFEST.in refers to external-media-test-requirements.txt, but it should be requirements.txt https://dxr.mozilla.org/mozilla-central/source/dom/media/test/external/MANIFEST.in You can test your fix locally by creating a virtualenv and running 'python setup.py install' from /dom/media/test/external: right now the output includes this warning > reading manifest template 'MANIFEST.in' > warning: no files found matching 'external-media-tests-requirements.txt'
Reporter | ||
Updated•8 years ago
|
Assignee: nobody → ceridwenv
Assignee | ||
Comment 1•8 years ago
|
||
This MANIFEST.in contained the wrong file name, external-media-tests-requirements.txt rather than requirements.txt. Review commit: https://reviewboard.mozilla.org/r/41165/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/41165/
Assignee | ||
Comment 2•8 years ago
|
||
Comment on attachment 8732424 [details] MozReview Request: Bug 1257983 - Fix MANIFEST.in in external-media-tests package; r?maja_zf Review request updated; see interdiff: https://reviewboard.mozilla.org/r/41165/diff/1-2/
Attachment #8732424 -
Attachment description: MozReview Request: Bug 1257983 - Fix MANIFEST.in in external-media-tests package → MozReview Request: Bug 1257983 - Fix MANIFEST.in in external-media-tests package; r?maja_zf
Attachment #8732424 -
Flags: review?(mjzffr)
Reporter | ||
Comment 3•8 years ago
|
||
Comment on attachment 8732424 [details] MozReview Request: Bug 1257983 - Fix MANIFEST.in in external-media-tests package; r?maja_zf https://reviewboard.mozilla.org/r/41165/#review37795 Thanks, Cara!
Attachment #8732424 -
Flags: review?(mjzffr) → review+
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c6897fa8a0c2
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Updated•6 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•