Closed
Bug 1258000
Opened 8 years ago
Closed 8 years ago
jit_test.py should print error if test list is empty after filtering
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: shu, Unassigned)
Details
Attachments
(1 file)
1.22 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
Right now it fails somewhere later with more cryptic errors.
Reporter | ||
Comment 1•8 years ago
|
||
Attachment #8732409 -
Flags: review?(sphink)
Comment 2•8 years ago
|
||
Comment on attachment 8732409 [details] [diff] [review] Make jit_test.py print a nice error message if test list is empty after filtering. Review of attachment 8732409 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/jit-test/jit_test.py @@ +234,5 @@ > + if not test_list: > + print("No tests found matching command line arguments after filtering.", > + file=sys.stderr) > + sys.exit(0) > + I'm waffling on the right status code for this. Usually it means an error, so sys.exit(1) would be better. But I hate having special cases. So I think what you did is probably better.
Attachment #8732409 -
Flags: review?(sphink) → review+
Comment 4•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/fd8964d81f84
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•