1258056 - Propagate the window opener full page zoom across the IPC layer

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[(no longer active)]

Currently the opener's full page zoom is not transmitted across processes, so the contentviewer that gets created for the opened window will have an inconsistent zoom level.  This makes test_window_open_units.html fail.

Comment 1

[(no longer active)]

Attachment: Propagate the window opener full page zoom across the IPC layer

Comment 2

[(no longer active)]

Note that I added the zoom argument to openWindow2 as optional in order to avoid the risk of breaking add-ons, even though I can't find an add-on that depends on openWindow2 on MXR...

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

I don't understand this bug. Why do we need to propagate the zoom level in e10s, but not in non-e10s.
I thought the zoom level handling was all in content preferences.
ContentPrefService2.jsm and http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser-fullZoom.js#216 etc.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8733008 [details] [diff] [review]
Propagate the window opener full page zoom across the IPC layer

and we don't do any this kind of automatic zoom level transferring in non-e10s either.
Newly opened window uses the zoom level which based on the domain of the page.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

(feel free to re-ask review if I somehow misunderstood this.)

Comment 6

[(no longer active)]

Comment on attachment 8733008 [details] [diff] [review]
Propagate the window opener full page zoom across the IPC layer

We do transfer this in non-e10s windows using this code: <https://dxr.mozilla.org/mozilla-central/source/embedding/components/windowwatcher/nsWindowWatcher.cpp?case=true&from=SizeOpenedDocShellItem#2077>.  Here, aParent is the *opener* window.  This was done in bug 594140 which added the test that is failing here.  My patch is preserving this behavior in e10s mode.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Oh, this isn't at all what the bug title says. openerZoom isn't set as a zoom level in the new document viewer or presshell or anything like that.
Looking.

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Or this is about what the bug title says, but not what comment 0 is about, or something like that.
Sorry, I misunderstood this.

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8733008 [details] [diff] [review]
Propagate the window opener full page zoom across the IPC layer

ok, fine.
The code in WindowWatcher is super confusing since the zoom level isn't actually used for zoom, but for something else.

Comment 10

[(no longer active)]

Sorry for how confusing this was.  Not sure if I used the right terminology everywhere...  But thanks for the review!

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fb0dd42729b8

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/fb0dd42729b8