Closed Bug 1258057 Opened 4 years ago Closed 2 years ago

Hide MozReview attachments and ensure all relevant actions and info are available in the MozReview table

Categories

(MozReview Graveyard :: Integration: Bugzilla, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: botond, Unassigned)

References

Details

STR:
  Load bug 1219296 and look at the patches attached via MozReview.

Expected results:
  The order of the patches in the "MozReview Requests" section is
  the same as the order in the "Attachments" section.

Actual results:
  The orders are different. The order in the "MozReview Requests"
  section is correct.
This is still happening. A more recent example is the patch series in bug 1289909.
We should just ensure that all relevant actions and info from the MozReview attachments are present in the MozReview table, and then hiding these attachments.  See also bug 1227923, which this might actually fix.
Summary: MozReview commits are still out of order in bugzilla → Hide MozReview attachments and ensure all relevant actions and info are available in the MozReview table
Bug 1195661 should be fixed before this as well, otherwise it would be harder for people to request re-review and do re-review.
Depends on: 1195661
botond pointed out that, since attachments are ordered by creation time (more or less), if a commit is inserted we could obsolete all attachments that follow it and recreate them... but this would effectively remove any r+s, which could only be recreated as r+s from the author.
MozReview is now obsolete. Please use Phabricator instead. Closing this bug.
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.