Closed
Bug 1258081
Opened 8 years ago
Closed 8 years ago
Intermittent browser_computed_search-filter_escape-keypress.js | This test exceeded the timeout threshold. It should be rewritten or split up.
Categories
(DevTools :: Inspector, defect, P2)
DevTools
Inspector
Tracking
(firefox50 wontfix, firefox51 fixed, firefox52 fixed)
RESOLVED
FIXED
Firefox 52
People
(Reporter: philor, Assigned: pbro)
Details
(Keywords: intermittent-failure, Whiteboard: [btpp-backlog])
Attachments
(1 file)
1.24 KB,
patch
|
pbro
:
review+
|
Details | Diff | Splinter Review |
Assignee | ||
Comment 1•8 years ago
|
||
Triaging. Filter on CLIMBING SHOES
Priority: -- → P3
Whiteboard: [btpp-backlog]
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 5•8 years ago
|
||
This hasn't been failing since September 18th, so maybe should go back to being a P3. Having said this, this should be a simple fix. The test does pass, it's only really slow on Linux debug. The logs contain the usual: INFO Leaving test bound INFO Removing tab. INFO Tab removed and finished closing And then: INFO TEST-UNEXPECTED-FAIL | devtools/client/inspector/computed/test/browser_computed_search-filter_escape-keypress.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. - And finally: INFO TEST-OK | devtools/client/inspector/computed/test/browser_computed_search-filter_escape-keypress.js | took 50932ms So, we should simply add a requestLongerTimeout here, because the test takes just a bit longer than the threshold of 45seconds, and only on Linux debug, so no real sense in trying to fix the test here since it's very unlikely to start failing on other platforms.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → pbrosset
Status: NEW → ASSIGNED
Pushed by pbrosset@mozilla.com: https://hg.mozilla.org/integration/fx-team/rev/3547d48e7782 Wait longer for browser_computed_search-filter_escape-keypress.js to pass; r=test-only
Assignee | ||
Comment 7•8 years ago
|
||
For info, here's the patch I just push. This is a test-only change, so r=test-only, and I just added a requestLongerTimeout, so no try push here.
Attachment #8797539 -
Flags: review+
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3547d48e7782
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Comment 9•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/f3123813ac97
status-firefox51:
--- → fixed
Flags: in-testsuite-
Updated•8 years ago
|
status-firefox50:
--- → wontfix
Updated•6 years ago
|
Product: Firefox → DevTools
Updated•3 years ago
|
Component: Inspector: Computed → Inspector
You need to log in
before you can comment on or make changes to this bug.
Description
•