Closed Bug 1258081 Opened 6 years ago Closed 5 years ago

Intermittent browser_computed_search-filter_escape-keypress.js | This test exceeded the timeout threshold. It should be rewritten or split up.

Categories

(DevTools :: Inspector, defect, P2)

defect

Tracking

(firefox50 wontfix, firefox51 fixed, firefox52 fixed)

RESOLVED FIXED
Firefox 52
Tracking Status
firefox50 --- wontfix
firefox51 --- fixed
firefox52 --- fixed

People

(Reporter: philor, Assigned: pbro)

Details

(Keywords: intermittent-failure, Whiteboard: [btpp-backlog])

Attachments

(1 file)

Triaging. Filter on CLIMBING SHOES
Priority: -- → P3
Whiteboard: [btpp-backlog]
Triaging. Filter on CLIMBING SHOES
Priority: P3 → P2
This hasn't been failing since September 18th, so maybe should go back to being a P3.
Having said this, this should be a simple fix.
The test does pass, it's only really slow on Linux debug.

The logs contain the usual:
INFO Leaving test bound
INFO Removing tab.
INFO Tab removed and finished closing

And then:
INFO TEST-UNEXPECTED-FAIL | devtools/client/inspector/computed/test/browser_computed_search-filter_escape-keypress.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. -

And finally:
INFO TEST-OK | devtools/client/inspector/computed/test/browser_computed_search-filter_escape-keypress.js | took 50932ms

So, we should simply add a requestLongerTimeout here, because the test takes just a bit longer than the threshold of 45seconds, and only on Linux debug, so no real sense in trying to fix the test here since it's very unlikely to start failing on other platforms.
Assignee: nobody → pbrosset
Status: NEW → ASSIGNED
Pushed by pbrosset@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/3547d48e7782
Wait longer for browser_computed_search-filter_escape-keypress.js to pass; r=test-only
Attached patch timeout.diffSplinter Review
For info, here's the patch I just push. This is a test-only change, so r=test-only, and I just added a requestLongerTimeout, so no try push here.
Attachment #8797539 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/3547d48e7782
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Product: Firefox → DevTools
Component: Inspector: Computed → Inspector
You need to log in before you can comment on or make changes to this bug.