Closed Bug 1258099 Opened 8 years ago Closed 8 years ago

Update the apk upload script to manage v15 instead v11

Categories

(Release Engineering :: Applications: MozharnessCore, defect)

defect
Not set
normal

Tracking

(firefox48 fixed)

RESOLVED FIXED
Tracking Status
firefox48 --- fixed

People

(Reporter: Sylvestre, Assigned: primer, Mentored)

References

Details

(Whiteboard: [good first bug][lang=Python])

Attachments

(1 file)

This is a trivial bug, if someone wants to work on it during the week end, here it is.
The file is here:
https://hg.mozilla.org/mozilla-central/file/tip/testing/mozharness/scripts/push_apk.py
replacing 11 to 15 is enough here.
Assignee: sledru → nobody
Mentor: sledru
Whiteboard: [good first bug][lang=Python]
Summary: Update the apk upload scrpit to manage v15 instead v11 → Update the apk upload script to manage v15 instead v11
Hi,

I'm new to to open-source development though the changes were quite trivial, I may have done some mistake. Moreover I would like to contribute more & need mentor for contributing more.

Regards,
Primer
Flags: needinfo?(sledru)
The patch is perfect, thanks! :)

Just a small comment, on the attachment, you are supposed to request a review:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch#Getting_the_patch_reviewed

In the commit author, you probably want your real name, no?
Assignee: nobody → xorprimer
Flags: needinfo?(sledru)
Attachment #8732905 - Flags: review?(sledru)
Hi :sylvestre,

Added you in reviewer :)

Thanks,
Primer
Could you answer to my question in comment  #3? Thanks
Hi,

Name is fine I think. Moreover I PM'ed you please check

Thanks
Comment on attachment 8732905 [details] [diff] [review]
bug1258099_v11tov15fix.diff

Good, thanks

Now, add "checkin-needed" in the list of keywords so that a sheriff can land a change for you.
Attachment #8732905 - Flags: review?(sledru) → review+
Keywords: checkin-needed
Keywords: checkin-needed
Hey :sylvestre,

Do I need to do anything for comment #9 ?
https://hg.mozilla.org/mozilla-central/rev/11ee5f2e1215
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Nope, I took care of the landing for you.
See Also: → 1384482
You need to log in before you can comment on or make changes to this bug.