Closed
Bug 1258145
Opened 8 years ago
Closed 8 years ago
Remove `waitForPromise` from the xpcshell tests
Categories
(Core :: DOM: Notifications, defect)
Core
DOM: Notifications
Tracking
()
RESOLVED
FIXED
mozilla48
People
(Reporter: lina, Assigned: lina)
References
Details
Attachments
(1 file)
33.36 KB,
patch
|
wchen
:
review+
|
Details | Diff | Splinter Review |
For some of the xpcshell test failures that RyanVM linked to (https://mzl.la/1TkDLCh), I wonder if we're just not waiting long enough (currently 5 seconds). Dragana suggested this in bug 1164277, comment 8. I think we should remove our own timers and let the harness deal with it: https://dxr.mozilla.org/mozilla-central/rev/b3006e4e09af81825badbad69fa3e8c546c7507c/testing/xpcshell/runxpcshelltests.py#47
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8732559 -
Flags: review?(wchen)
Updated•8 years ago
|
Updated•8 years ago
|
Attachment #8732559 -
Flags: review?(wchen) → review+
Comment 3•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/34b0a503329a
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Updated•8 years ago
|
Assignee: nobody → kcambridge
Comment 4•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/477b227b6224
status-firefox47:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•