Closed Bug 1258145 Opened 4 years ago Closed 4 years ago

Remove `waitForPromise` from the xpcshell tests

Categories

(Core :: DOM: Push Notifications, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox47 --- fixed
firefox48 --- fixed

People

(Reporter: Lina, Assigned: Lina)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

For some of the xpcshell test failures that RyanVM linked to (https://mzl.la/1TkDLCh), I wonder if we're just not waiting long enough (currently 5 seconds). Dragana suggested this in bug 1164277, comment 8.

I think we should remove our own timers and let the harness deal with it: https://dxr.mozilla.org/mozilla-central/rev/b3006e4e09af81825badbad69fa3e8c546c7507c/testing/xpcshell/runxpcshelltests.py#47
Attachment #8732559 - Flags: review?(wchen)
Depends on: 1206969
Blocks: 1206969
No longer depends on: 1206969
Attachment #8732559 - Flags: review?(wchen) → review+
https://hg.mozilla.org/mozilla-central/rev/34b0a503329a
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.