1258173 - Toolbox becomes unresponsive after clearing recordings recorded via console.profile() and via performance tab

Status: RESOLVED INVALID

(DevTools :: Performance Tools (Profiler/Timeline), defect, P2)

Description

[Jomy Emmanuel [:je_007]]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0
Build ID: 20160304114926

Steps to reproduce:

1. Open developer console.
2. Record a recording via performance tab.
3. Record another recording via console.profile()
4. Go to performance tab and clear recordings. Recording via console.profile() will remain. Recording via performance tab will be removed.
5. Stop recording via console.profileEnd()
6. Try to close developer console via 'x' button of console.


Actual results:

Developer console does not closes. It becomes unresponsive after trying to close via 'x' button. Recording via performance tab will not be possible thereafter. Accessing history of commands entered in console (via up button of keyboard) will also not be possible. Popping out console and then closing works, however, it is not possible to open developer console after that.


Expected results:

Developer console should have closed. Opening developer console again after closing the earlier one should also be possible.

Comment 1

[Brian Grinstead [:bgrins]]

I can confirm this.  Looks like the perf frontend is throwing some errors in this case.  The console empties out because destroy is called on it when the x is clicked (same thing happens with inspector).  So it appears somehow perf tool is blocking toolbox shutdown when it gets into this state.  Three errors I see in the Browser Console after profileEnd is called:

NS_ERROR_FAILURE: markers-overview.js:169
---
InvalidStateError: An attempt was made to use an object that is not, or is no longer, usable Graphs.js:722
---
A promise chain failed to handle a rejection. Did you forget to '.catch', or did you forget to 'return'?
See https://developer.mozilla.org/Mozilla/JavaScript_code_modules/Promise.jsm/Promise

Date: Mon Mar 21 2016 09:08:10 GMT-0700 (PDT)
Full Message: 
Full Stack: JS frame :: resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/performance/modules/widgets/markers-overview.js :: MarkersOverview.prototype<.buildGraphImage :: line 169
JS frame :: resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/shared/widgets/Graphs.js :: AbstractCanvasGraph.prototype.setData :: line 287
JS frame :: resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/performance/modules/widgets/graphs.js :: GraphsController.prototype.render< :: line 224
JS frame :: resource://gre/modules/Task.jsm :: TaskImpl_run :: line 319
JS frame :: resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js :: Handler.prototype.process :: line 937
JS frame :: resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js :: this.PromiseWalker.walkerLoop :: line 816

Comment 2

[Victor Porof [:vporof][:vp]]

Thanks Jomy for filing and bgrins for reproducing.

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

This report is related to the old DevTools Profiler.
The Performance panel now points to the new Firefox profiler available at profiler.firefox.com
Closing as Invalid bug