Closed Bug 1258197 Opened 4 years ago Closed 4 years ago

Recordings list empty label text has a different background color than its parent container

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect)

defect
Not set

Tracking

(firefox46 unaffected, firefox47 verified, firefox48 verified)

VERIFIED FIXED
Firefox 48
Tracking Status
firefox46 --- unaffected
firefox47 --- verified
firefox48 --- verified

People

(Reporter: vporof, Assigned: vporof)

Details

Attachments

(2 files)

Everything has a background except that label, which gets its background from the .theme-body since everything is transparent underneath.
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Attachment #8732627 - Flags: review?(jsantell)
Attachment #8732627 - Flags: review?(jsantell) → review+
https://hg.mozilla.org/integration/fx-team/rev/8bcc1369627e4017fc5adcd3284ecf330909ffa1
Bug 1258197 - Recordings list empty label text has a different background color than its parent container, r=jsantell
https://hg.mozilla.org/mozilla-central/rev/8bcc1369627e
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Comment on attachment 8732627 [details] [diff] [review]
sidebar-empty-label-background.patch

Approval Request Comment
[Feature/regressing bug #]: Bug 1184644 
[User impact if declined]: see attachment 8732630 [details]
[Describe test coverage new/current, TreeHerder]: has been in Nightly for almost a week
[Risks and why]: very low, small CSS change.
[String/UUID change made/needed]: None
Attachment #8732627 - Flags: approval-mozilla-aurora?
Thanks for catching this Victor!
Victor, could you please verify this issue is fixed as expected on a latest Nightly build? Thanks!
Flags: needinfo?(vporof)
Comment on attachment 8732627 [details] [diff] [review]
sidebar-empty-label-background.patch

CSS only, low risk, Aurora47+
Attachment #8732627 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Can't work on this right now, busy with Tofino.
Flags: needinfo?(vporof)
Status: RESOLVED → VERIFIED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.