Closed Bug 1258228 Opened 4 years ago Closed 4 years ago

create special child accessibles in owner's constructor

Categories

(Core :: Disability Access APIs, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: surkov, Assigned: surkov)

Details

Attachments

(4 files)

No description provided.
Attached patch nch_comboboxSplinter Review
Assignee: nobody → surkov.alexander
Attachment #8732656 - Flags: review?(mzehe)
Attached patch image mapSplinter Review
Attachment #8732657 - Flags: review?(mzehe)
Attached patch outerdocSplinter Review
Attachment #8732658 - Flags: review?(mzehe)
Attached patch win32 objSplinter Review
Attachment #8732659 - Flags: review?(mzehe)
Attachment #8732656 - Flags: review?(mzehe) → review+
Attachment #8732657 - Flags: review?(mzehe) → review+
Comment on attachment 8732658 [details] [diff] [review]
outerdoc

>+  // Request document accessible for the content document to make sure it's
>+  // created. It will appended to outerdoc accessible children asynchronously.
Nit: "it will be appended..."
Attachment #8732658 - Flags: review?(mzehe) → review+
Comment on attachment 8732659 [details] [diff] [review]
win32 obj

> void
> HTMLWin32ObjectOwnerAccessible::CacheChildren()
> {
>-  if (mNativeAccessible)
>-    AppendChild(mNativeAccessible);
> }
Why is this not removed in its entirety, just emptied? r=me with that question answered or the method being removed.
Attachment #8732659 - Flags: review?(mzehe) → review+
(In reply to Marco Zehe (:MarcoZ) from comment #6)

> > void
> > HTMLWin32ObjectOwnerAccessible::CacheChildren()
> > {
> >-  if (mNativeAccessible)
> >-    AppendChild(mNativeAccessible);
> > }
> Why is this not removed in its entirety, just emptied? r=me with that
> question answered or the method being removed.

to not pick up a base class implementation
https://hg.mozilla.org/integration/mozilla-inbound/rev/d32bcd5bd2cf9a0e504d6ad78583c7f95bc1ccf3
Bug 1258228 - create special child accessibles in owner's constructor, part1, r=marcoz

https://hg.mozilla.org/integration/mozilla-inbound/rev/ed20f4a35b9a213167c869e93a30fc85ee9d78f4
Bug 1258228 - create special child accessibles in owner's constructor, part2, r=marcoz

https://hg.mozilla.org/integration/mozilla-inbound/rev/cc5e38a943bb74b37182f5650bd12e2cfc0bac26
Bug 1258228 - create special child accessibles in owner's constructor, part3, r=marcoz

https://hg.mozilla.org/integration/mozilla-inbound/rev/2724b036ed2b3a3bab2987a563ccc7fc64488618
Bug 1258228 - create special child accessibles in owner's constructor, part4, r=marcoz
You need to log in before you can comment on or make changes to this bug.