Closed Bug 1258271 Opened 8 years ago Closed 8 years ago

Remove arguments from MediaDecoderStateMachine::HaveEnoughDecodedAudio()

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

Details

Attachments

(1 file)

Since we always pass |mAmpleAudioThresholdUsecs * mPlaybackRate| to HaveEnoughDecodedAudio(), we can remove the argument and compute it inside HaveEnoughDecodedAudio(). It will also be consistent with the signature of HaveEnoughDecodedVideo().
Assignee: nobody → jwwang
Attachment #8732712 - Flags: review?(bechen)
Attachment #8732712 - Flags: review?(bechen) → review+
Comment on attachment 8732712 [details]
MozReview Request: Bug 1258271 - Remove arguments from MediaDecoderStateMachine::HaveEnoughDecodedAudio().

https://reviewboard.mozilla.org/r/41273/#review37833
Thanks!
https://hg.mozilla.org/mozilla-central/rev/c4ed371b3a33
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.