Closed Bug 1258303 Opened 8 years ago Closed 8 years ago

Implement Yahoo! Search updates on /firstrun/learnmore/

Categories

(www.mozilla.org :: Pages & Content, defect)

Production
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: agibson, Assigned: agibson)

References

Details

Attachments

(2 files)

      No description provided.
Blocks: 1256384
Assignee: nobody → agibson
Status: NEW → ASSIGNED
Attached file GitHub pull request
Will put this up on a demo server today
Still WIP, but this is now up on a demo server:

https://bedrock-demo-agibson.us-west.moz.works/en-US/firefox/45.0/firstrun/learnmore/?v=1
https://bedrock-demo-agibson.us-west.moz.works/en-US/firefox/45.0/firstrun/learnmore/?v=2

To see/click the "Try it now" button, you need to white list the above domain for UITour. See the bedrock docs for how to do this:

http://bedrock.readthedocs.org/en/latest/uitour.html#local-development
Demo links in Comment 5 have been updated as per discussion in recent email thread. The only thing that changes in regard to layout between versions now is the copy (main heading). Visual hierarchy stays the same.
(In reply to Alex Gibson [:agibson] from comment #6)
> Demo links in Comment 5 have been updated as per discussion in recent email
> thread. The only thing that changes in regard to layout between versions now
> is the copy (main heading). Visual hierarchy stays the same.

Layout is now correct. Looks good, Alex. 



Additional update from Winston and legal:

Add the following link/copy below the image. Will need-info Matt for design direction (alignment, link color, etc), but feel free to take a first pass. I see this as a smaller, tertiary link, just a few pixels below the image. 

Copy - "Yahoo is one of Mozilla's search partners. Learn more."

Learn More link - https://blog.mozilla.org/blog/2015/11/11/a-new-yahoo-search-experience-for-firefox-users-in-u-s/
Flags: needinfo?(mternoway)
Need-info Troy - Could you double-check that copy in links is as expected? See comment 5.
Flags: needinfo?(tpalmer)
(In reply to Holly Habstritt Gaal [:Habber] from comment #7)
> Additional update from Winston and legal:
> 
> Add the following link/copy below the image. Will need-info Matt for design
> direction (alignment, link color, etc), but feel free to take a first pass.
> I see this as a smaller, tertiary link, just a few pixels below the image. 
> 
> Copy - "Yahoo is one of Mozilla's search partners. Learn more."
> 
> Learn More link -
> https://blog.mozilla.org/blog/2015/11/11/a-new-yahoo-search-experience-for-
> firefox-users-in-u-s/

Added a link as above below the browser chrome images - I chose our regular base font size, and our standard yellow link color for "Learn more.". Can change this based on Matt's feedback if needed. Thanks.
(In reply to Holly Habstritt Gaal [:Habber] from comment #8)
> Need-info Troy - Could you double-check that copy in links is as expected?
> See comment 5.

Copy looks good. Thanks!
Flags: needinfo?(tpalmer)
(In reply to Alex Gibson [:agibson] from comment #9)
> (In reply to Holly Habstritt Gaal [:Habber] from comment #7)
> > Additional update from Winston and legal:
> > 
> > Add the following link/copy below the image. Will need-info Matt for design
> > direction (alignment, link color, etc), but feel free to take a first pass.
> > I see this as a smaller, tertiary link, just a few pixels below the image. 
> > 
> > Copy - "Yahoo is one of Mozilla's search partners. Learn more."
> > 
> > Learn More link -
> > https://blog.mozilla.org/blog/2015/11/11/a-new-yahoo-search-experience-for-
> > firefox-users-in-u-s/
> 
> Added a link as above below the browser chrome images - I chose our regular
> base font size, and our standard yellow link color for "Learn more.". Can
> change this based on Matt's feedback if needed. Thanks.


Alex, placement and size of legal line looks good to me.

MT
Flags: needinfo?(mternoway)
Matt, can you please provide a new @2x browser image as per the request from the email discussion?

"Yahoo Logo - request to amp up the logo in the screen shot / search mock. Can we try 2x to 3x larger (as long as it stays in ratio with the search box)"

Thanks in advance
Flags: needinfo?(mternoway)
Hey Alex, here is a link to the updated browser chrome PSD which includes the larger Yahoo logo on the search.

https://www.dropbox.com/s/4ccuvczw5xl2jf6/browser-chrome.psd?dl=0
Flags: needinfo?(mternoway)
Attached image browser-chrome_2x.png
2x png of browser chrome as well.
Updated browser image with the larger Yahoo! logo is now up on demo linked in Comment 5 ^
The three funnelcakes related to this are 63, 64, and 65.

63 is going to be the control.

So if we could make one variant:

https://www.mozilla.org/%LOCALE%/firefox/%VERSION%/firstrun/learnmore/?f=64
and the other variant
https://www.mozilla.org/%LOCALE%/firefox/%VERSION%/firstrun/learnmore/?f=65

That would be great.

I'll also be passing f=63 to the control so it can be tracked as well.
I'm running some tests of my funnelcake and I get the firstrun page and the windows 10 welcome page, but I do not get the firstrun/learnmore page.

Is there some other preference that needs to be flipped so we show the learnmore instead of the windows 10?
> Is there some other preference that needs to be flipped so we show the learnmore instead of the windows 10?

To answer my own question, you have to set browser.usedOnWindows10 to true
What's the timeline for getting this in? We're working on the builds now.
(In reply to mkaply from comment #19)
> What's the timeline for getting this in? We're working on the builds now.

This is just finishing up in code review, should be merged and pushed shortly.
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/139762ae18a45cce6b7bdb7c34e5cc7073cfbb77
[fix bug 1258303] Implement Yahoo! Search updates on /firstrun/learnmore/

https://github.com/mozilla/bedrock/commit/dffa98cf3c7f97fca8c67aa8a3c43302983d80e6
Merge pull request #4000 from alexgibson/bug-1258303-yahoo-firstrun-learnmore

[fix bug 1258303] Implement Yahoo! Search updates on /firstrun/learnmore
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
This change has reached stage and will go out in our next prod push, either later today or tomorrow at the latest:

https://www.allizom.org/en-US/firefox/45.0/firstrun/learnmore/?f=64
https://www.allizom.org/en-US/firefox/45.0/firstrun/learnmore/?f=65
If I should open a new bug, please let me know.

In testing this, the title of the additional page is Mozilla Firefox Web Browser -- Mozilla so you end up with two tabs with the same title. With the protection additional tab, you see "More protection. The mos..."

Should we give this a unique title so people don't think it's a duplicate of the first run?
(In reply to Mike Kaply [:mkaply] from comment #25)
> If I should open a new bug, please let me know.
> 
> In testing this, the title of the additional page is Mozilla Firefox Web
> Browser -- Mozilla so you end up with two tabs with the same title. With the
> protection additional tab, you see "More protection. The mos..."
> 
> Should we give this a unique title so people don't think it's a duplicate of
> the first run?

Please open a new bug, thanks.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: