1258310 - [Windows] New tab icon in the tab bar is blurry on hidpi

Status: RESOLVED WORKSFORME

(Firefox :: Theme, defect)

Description

[Chris Lord [:cwiiis]]

Attachment: Screenshot 2016-03-21 10.07.27.png

I guess this is a regression, as they should have been fixed by bug 1188785 I think? But the last tab separator is blurry when using DPI scaling, as is the new tab icon. See attached screenshot.

Is there any reason we can't use SVGs for these icons?

Comment 1

[Chris Lord [:cwiiis]]

Huh, ok, I just noticed in the screenshot that it's the last and the one two before it that are blurry - it seems this depends on the number of tabs you have open (/ window size?). The new tab icon is always blurry though.

Comment 2

[:Gijs (he/him)]

I'm fairly sure the separator thing is essentially a dupe of bug 1189212 or bug 1172905. Morphing to be just about the new tab icon.

(In reply to Chris Lord [:cwiiis] from comment #0)
> Is there any reason we can't use SVGs for these icons?

Performance. See bug 1054016 and the talos runs there.

Comment 3

[Tim Nguyen :ntim]

(In reply to :Gijs Kruitbosch from comment #2)
> I'm fairly sure the separator thing is essentially a dupe of bug 1189212 or
> bug 1172905. Morphing to be just about the new tab icon.
> 
> (In reply to Chris Lord [:cwiiis] from comment #0)
> > Is there any reason we can't use SVGs for these icons?
I'm not sure what you mean, we're using SVG for the new tab icon after bug 1188785, I'm guessing the SVG isn't being pixel snapped for that specific DPI ?

Comment 4

[Chris Lord [:cwiiis]]

(In reply to Tim Nguyen [:ntim] from comment #3)
> (In reply to :Gijs Kruitbosch from comment #2)
> > I'm fairly sure the separator thing is essentially a dupe of bug 1189212 or
> > bug 1172905. Morphing to be just about the new tab icon.
> > 
> > (In reply to Chris Lord [:cwiiis] from comment #0)
> > > Is there any reason we can't use SVGs for these icons?
> I'm not sure what you mean, we're using SVG for the new tab icon after bug
> 1188785, I'm guessing the SVG isn't being pixel snapped for that specific
> DPI ?

Ah, I just assumed the blurriness was from scaling, but I guess pixel alignment is the problem then.

Comment 5

[:Gijs (he/him)]

(In reply to Tim Nguyen [:ntim] from comment #3)
> (In reply to :Gijs Kruitbosch from comment #2)
> > I'm fairly sure the separator thing is essentially a dupe of bug 1189212 or
> > bug 1172905. Morphing to be just about the new tab icon.
> > 
> > (In reply to Chris Lord [:cwiiis] from comment #0)
> > > Is there any reason we can't use SVGs for these icons?
> I'm not sure what you mean, we're using SVG for the new tab icon after bug
> 1188785, I'm guessing the SVG isn't being pixel snapped for that specific
> DPI ?

It's not pixel-snapped at all. Specifying crispedges leads to it being pixelsnapped off-center.

Of course, the real issue here is that the source file is 16px wide, with the actual + shape 12 px wide and tall, and the bars being 2px wide.

This means the vertical bar is aligned at 7px (which centers the 2px width around the 8px mark). At 150% dpi, that multiplies to pixel... 10.5. The whole thing is now 16 * 1.5 == 24 hardware pixels, and the bar should be 3 pixels wide, and you can't actually center 3px on 24px on pixel boundaries, because there should be 10.5 pixel on either side. So I'm not sure what the desired outcome is if not the current state. Personally I find the blur very hard to see in the screenshot, but that's just me. Stephen?

Comment 6

[:Gijs (he/him)]

Seems like the OS X one is 10 CSS pixels wide and just as thick (so slightly smaller and thereby looks slightly fatter, so to speak), which avoids this issue because then there's 4 CSS pixels on either side, which multiplies nicely for the allowed win10 scale factors. Can we just do that on Windows, too? Stephen?

Comment 7

[Tim Nguyen :ntim]

Chris, Is this fixed with Photon ?

Comment 8

[Chris Lord [:cwiiis]]

(In reply to Tim Nguyen :ntim from comment #7)

Chris, Is this fixed with Photon ?

It looks perfectly sharp for me in the current release (66.0.2). My eyes have deterioriated a little since I opened this bug though :)

Comment 9

[:Gijs (he/him)]

Thanks!