Closed
Bug 1258316
Opened 8 years ago
Closed 8 years ago
maximize() should maximize the window correctly so its original size and location can be restored
Categories
(Remote Protocol :: Marionette, defect)
Tracking
(firefox48 fixed, firefox49 fixed)
RESOLVED
FIXED
mozilla49
People
(Reporter: whimboo, Unassigned)
References
Details
(Keywords: pi-marionette-server)
Attachments
(1 file)
As raised on bug 1257035 comment 2: I also feel that the API is wrong. As of now we move the window to (0,0) and resize it to the screen width and height. https://dxr.mozilla.org/mozilla-central/source/testing/marionette/driver.js#2680 Instead `window.maximize()` should be called so that a following `window.restore()` can restore the previous window constraints. By first moving and than resizing the window we will loose those.
Reporter | ||
Updated•8 years ago
|
Keywords: ateam-marionette-server
Comment 2•8 years ago
|
||
This allows use to be able restore the window size if we wanted to. Review commit: https://reviewboard.mozilla.org/r/50957/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/50957/
Attachment #8749450 -
Flags: review?(ato)
Comment 4•8 years ago
|
||
Comment on attachment 8749450 [details] MozReview Request: Bug 1258316 - Have marionette call maximize() on window instead of resize r?ato Review request updated; see interdiff: https://reviewboard.mozilla.org/r/50957/diff/1-2/
Comment 5•8 years ago
|
||
Comment on attachment 8749450 [details] MozReview Request: Bug 1258316 - Have marionette call maximize() on window instead of resize r?ato https://reviewboard.mozilla.org/r/50957/#review47713 LGTM, but there are Windows failures.
Attachment #8749450 -
Flags: review?(ato) → review+
Comment 7•8 years ago
|
||
Comment on attachment 8749450 [details] MozReview Request: Bug 1258316 - Have marionette call maximize() on window instead of resize r?ato Review request updated; see interdiff: https://reviewboard.mozilla.org/r/50957/diff/2-3/
Comment 9•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/71decd23df75
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Comment 11•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/58cc44dac6d5
status-firefox48:
--- → fixed
Comment 12•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/58cc44dac6d5
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•