1258316 - maximize() should maximize the window correctly so its original size and location can be restored

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

As raised on bug 1257035 comment 2:

I also feel that the API is wrong. As of now we move the window to (0,0) and resize it to the screen width and height. 

https://dxr.mozilla.org/mozilla-central/source/testing/marionette/driver.js#2680

Instead `window.maximize()` should be called so that a following `window.restore()` can restore the previous window constraints. By first moving and than resizing the window we will loose those.

Comment 1

[David Burns :automatedtester]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ebfb4146363a

Comment 2

[David Burns :automatedtester]

Attachment: MozReview Request: Bug 1258316 - Have marionette call maximize() on window instead of resize r?ato

This allows use to be able restore the window size if we wanted to.

Review commit: https://reviewboard.mozilla.org/r/50957/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/50957/

Comment 3

[David Burns :automatedtester]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1c8b53eb5a15

Comment 4

[David Burns :automatedtester]

Comment on attachment 8749450 [details]
MozReview Request: Bug 1258316 - Have marionette call maximize() on window instead of resize r?ato

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/50957/diff/1-2/

Comment 5

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8749450 [details]
MozReview Request: Bug 1258316 - Have marionette call maximize() on window instead of resize r?ato

https://reviewboard.mozilla.org/r/50957/#review47713

LGTM, but there are Windows failures.

Comment 6

[David Burns :automatedtester]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1b41e6b488ee

Comment 7

[David Burns :automatedtester]

Comment on attachment 8749450 [details]
MozReview Request: Bug 1258316 - Have marionette call maximize() on window instead of resize r?ato

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/50957/diff/2-3/

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/71decd23df75

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/71decd23df75

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/58cc44dac6d5

Comment 12

[David Burns :automatedtester]

https://hg.mozilla.org/releases/mozilla-aurora/rev/58cc44dac6d5