Closed Bug 1258316 Opened 4 years ago Closed 4 years ago

maximize() should maximize the window correctly so its original size and location can be restored

Categories

(Testing :: Marionette, defect)

47 Branch
defect
Not set

Tracking

(firefox48 fixed, firefox49 fixed)

RESOLVED FIXED
mozilla49
Tracking Status
firefox48 --- fixed
firefox49 --- fixed

People

(Reporter: whimboo, Unassigned)

References

Details

(Keywords: pi-marionette-server)

Attachments

(1 file)

As raised on bug 1257035 comment 2:

I also feel that the API is wrong. As of now we move the window to (0,0) and resize it to the screen width and height. 

https://dxr.mozilla.org/mozilla-central/source/testing/marionette/driver.js#2680

Instead `window.maximize()` should be called so that a following `window.restore()` can restore the previous window constraints. By first moving and than resizing the window we will loose those.
Comment on attachment 8749450 [details]
MozReview Request: Bug 1258316 - Have marionette call maximize() on window instead of resize r?ato

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/50957/diff/1-2/
Comment on attachment 8749450 [details]
MozReview Request: Bug 1258316 - Have marionette call maximize() on window instead of resize r?ato

https://reviewboard.mozilla.org/r/50957/#review47713

LGTM, but there are Windows failures.
Attachment #8749450 - Flags: review?(ato) → review+
Comment on attachment 8749450 [details]
MozReview Request: Bug 1258316 - Have marionette call maximize() on window instead of resize r?ato

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/50957/diff/2-3/
https://hg.mozilla.org/mozilla-central/rev/71decd23df75
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Duplicate of this bug: 1139369
You need to log in before you can comment on or make changes to this bug.