Closed Bug 1258328 Opened 8 years ago Closed 8 years ago

HelperAppDialog: Replace deprecated toast API with Snackbars.jsm

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set
normal

Tracking

(firefox46 verified, firefox47 verified, firefox48 verified)

VERIFIED FIXED
Firefox 48
Tracking Status
firefox46 --- verified
firefox47 --- verified
firefox48 --- verified

People

(Reporter: sebastian, Assigned: sebastian, Mentored)

Details

(Whiteboard: [lang=java][good next bug])

Attachments

(1 file)

It seems like this even breaks the error dialog.
Assignee: nobody → s.kaspari
Status: NEW → ASSIGNED
Comment on attachment 8733333 [details]
MozReview Request: Bug 1258328 - HelperAppDialog: Replace deprecated toast API with Snackbars.jsm. r?grisha

https://reviewboard.mozilla.org/r/41731/#review38819

Looks good!
Attachment #8733333 - Flags: review?(gkruglov) → review+
https://hg.mozilla.org/integration/fx-team/rev/31071bd61e48933cd2b142701e5324d1830463f3
Bug 1258328 - HelperAppDialog: Replace deprecated toast API with Snackbars.jsm. r=grisha
https://hg.mozilla.org/mozilla-central/rev/31071bd61e48
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Comment on attachment 8733333 [details]
MozReview Request: Bug 1258328 - HelperAppDialog: Replace deprecated toast API with Snackbars.jsm. r?grisha

Aurora and Beta are affected too.

Approval Request Comment

[Feature/regressing bug #]: 

[User impact if declined]: If a download cannot be started then no error message is displayed.

[Describe test coverage new/current, TreeHerder]: Local testing.

[Risks and why]: Low. This is now a week in Nightly. Should be safe to uplift.

[String/UUID change made/needed]: -
Attachment #8733333 - Flags: approval-mozilla-beta?
Attachment #8733333 - Flags: approval-mozilla-aurora?
Comment on attachment 8733333 [details]
MozReview Request: Bug 1258328 - HelperAppDialog: Replace deprecated toast API with Snackbars.jsm. r?grisha

We should show download errors, please uplift this to aurora and beta. 
Sebastian can you verify this or help QE verify it on beta once it lands in beta 10 next week?
Flags: needinfo?(s.kaspari)
Attachment #8733333 - Flags: approval-mozilla-beta?
Attachment #8733333 - Flags: approval-mozilla-beta+
Attachment #8733333 - Flags: approval-mozilla-aurora?
Attachment #8733333 - Flags: approval-mozilla-aurora+
(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #7)
> We should show download errors, please uplift this to aurora and beta. 
> Sebastian can you verify this or help QE verify it on beta once it lands in
> beta 10 next week?

Sure!
Flags: needinfo?(s.kaspari)
Verified as fixed in builds:
- 48.0a1 2016-04-11;
- 47.0a2 2016-04-11;
Device: Nexus 5 (Android 6.0.1).
Verified as fixed in Firefox 46 Beta 10;
Device: Nexus 5 (Android 6.0.1).
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.