Closed
Bug 1258328
Opened 8 years ago
Closed 8 years ago
HelperAppDialog: Replace deprecated toast API with Snackbars.jsm
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox46 verified, firefox47 verified, firefox48 verified)
VERIFIED
FIXED
Firefox 48
People
(Reporter: sebastian, Assigned: sebastian, Mentored)
Details
(Whiteboard: [lang=java][good next bug])
Attachments
(1 file)
58 bytes,
text/x-review-board-request
|
Grisha
:
review+
lizzard
:
approval-mozilla-aurora+
lizzard
:
approval-mozilla-beta+
|
Details |
HelperAppDialog.js still uses the deprecated toast API[1]: https://dxr.mozilla.org/mozilla-central/rev/f14898695ee0dd14615914f3e1401f17df57fdd7/mobile/android/components/HelperAppDialog.js#189-207 These calls are automatically converted to show a snackbar but we should use the Snackbars.jsm API[2]. [1] https://developer.mozilla.org/en-US/Add-ons/Firefox_for_Android/API/window.NativeWindow/window.NativeWindow.toast [2] https://developer.mozilla.org/en-US/Add-ons/Firefox_for_Android/API/Snackbars.jsm
Assignee | ||
Comment 1•8 years ago
|
||
It seems like this even breaks the error dialog.
Assignee: nobody → s.kaspari
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/41731/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/41731/
Attachment #8733333 -
Flags: review?(gkruglov)
Comment 3•8 years ago
|
||
Comment on attachment 8733333 [details] MozReview Request: Bug 1258328 - HelperAppDialog: Replace deprecated toast API with Snackbars.jsm. r?grisha https://reviewboard.mozilla.org/r/41731/#review38819 Looks good!
Attachment #8733333 -
Flags: review?(gkruglov) → review+
Assignee | ||
Comment 4•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/31071bd61e48933cd2b142701e5324d1830463f3 Bug 1258328 - HelperAppDialog: Replace deprecated toast API with Snackbars.jsm. r=grisha
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/31071bd61e48
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Assignee | ||
Comment 6•8 years ago
|
||
Comment on attachment 8733333 [details] MozReview Request: Bug 1258328 - HelperAppDialog: Replace deprecated toast API with Snackbars.jsm. r?grisha Aurora and Beta are affected too. Approval Request Comment [Feature/regressing bug #]: [User impact if declined]: If a download cannot be started then no error message is displayed. [Describe test coverage new/current, TreeHerder]: Local testing. [Risks and why]: Low. This is now a week in Nightly. Should be safe to uplift. [String/UUID change made/needed]: -
Attachment #8733333 -
Flags: approval-mozilla-beta?
Attachment #8733333 -
Flags: approval-mozilla-aurora?
Comment 7•8 years ago
|
||
Comment on attachment 8733333 [details] MozReview Request: Bug 1258328 - HelperAppDialog: Replace deprecated toast API with Snackbars.jsm. r?grisha We should show download errors, please uplift this to aurora and beta. Sebastian can you verify this or help QE verify it on beta once it lands in beta 10 next week?
Flags: needinfo?(s.kaspari)
Attachment #8733333 -
Flags: approval-mozilla-beta?
Attachment #8733333 -
Flags: approval-mozilla-beta+
Attachment #8733333 -
Flags: approval-mozilla-aurora?
Attachment #8733333 -
Flags: approval-mozilla-aurora+
Assignee | ||
Comment 8•8 years ago
|
||
(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #7) > We should show download errors, please uplift this to aurora and beta. > Sebastian can you verify this or help QE verify it on beta once it lands in > beta 10 next week? Sure!
Flags: needinfo?(s.kaspari)
Comment 9•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/8e4ae231d797
status-firefox47:
--- → fixed
Comment 10•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/1e8bb8d3af50
status-firefox46:
--- → fixed
Comment 11•8 years ago
|
||
Verified as fixed in builds: - 48.0a1 2016-04-11; - 47.0a2 2016-04-11; Device: Nexus 5 (Android 6.0.1).
Comment 12•8 years ago
|
||
Verified as fixed in Firefox 46 Beta 10; Device: Nexus 5 (Android 6.0.1).
Status: RESOLVED → VERIFIED
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•