1258348 - Coverity missing nullcheck in Parser

Status: RESOLVED DUPLICATE of bug 1258379

(Core :: JavaScript Engine, defect)

Description

[Jason Orendorff [:jorendorff]]

________________________________________________________________________________________________________
*** CID 1357072:  Null pointer dereferences  (REVERSE_INULL)
/js/src/frontend/Parser.cpp: 4127 in js::frontend::Parser<js::frontend::FullParseHandler>::bindVar(js::frontend::BindData<js::frontend::FullParseHandler> *, JS::Handle<js::PropertyName *>, js::frontend::Parser<js::frontend::FullParseHandler>*)()
4121             // ensure that functionless scopes get the proper DEFVAR emits.)
4122             parser->handler.setFlag(pn, PND_DEOPTIMIZED);
4123
4124             // Synthesize a new 'var' binding if one does not exist.
4125             DefinitionNode last = pc->decls().lookupLast(name);
4126             Definition::Kind lastKind = parser->handler.getDefinitionKind(last);
>>>     CID 1357072:  Null pointer dereferences  (REVERSE_INULL)
>>>     Null-checking "last" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
4127             if (last && lastKind != Definition::VAR && lastKind != Definition::ARG) {
4128                 parser->handler.setFlag(parser->handler.getDefinitionNode(last), PND_CLOSED);
4129
4130                 Node synthesizedVarName = parser->newName(name);
4131                 if (!synthesizedVarName)
4132                     return false;

Comment 2

[Jason Orendorff [:jorendorff]]

Attachment: Silence Coverity warning about a missing nullcheck in Parser<FPH>::bindVar()