Closed Bug 1258361 Opened 4 years ago Closed 4 years ago

browser_net_streaming-response.js fails when trying to used shared promises

Categories

(DevTools :: Netmonitor, defect)

defect
Not set

Tracking

(firefox48 fixed)

RESOLVED FIXED
Firefox 48
Tracking Status
firefox48 --- fixed

People

(Reporter: jryans, Assigned: jryans)

References

Details

Attachments

(1 file)

Switching back to the shared promises in bug 1240804 appears to trigger a failure in the test browser_net_streaming-response.js.

As evidence of the failures, see https://treeherder.mozilla.org/#/jobs?repo=try&revision=2637451ab1e7.

It seems we need to explicitly wait for the editor the second time around.
Comment on attachment 8732839 [details]
MozReview Request: Bug 1258361 - Wait for second streaming response to display. r=vporof

https://reviewboard.mozilla.org/r/41399/#review37919
Attachment #8732839 - Flags: review?(vporof) → review+
backed out for failing test like https://treeherder.mozilla.org/logviewer.html#?job_id=8165246&repo=fx-team
Flags: needinfo?(jryans)
Looks like adding this fails *without* the promise changes landing at the same time... :/

I'll hold onto this then until I can land the promise changes.
Flags: needinfo?(jryans)
https://hg.mozilla.org/mozilla-central/rev/6a17a3d359ff
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.