Open Bug 1258365 Opened 5 years ago Updated 3 years ago

New style for popup previews

Categories

(DevTools :: Shared Components, defect, P3)

defect

Tracking

(Not tracked)

People

(Reporter: hholmes, Unassigned)

References

()

Details

(Whiteboard: [btpp-backlog])

Attachments

(1 file, 2 obsolete files)

Attached image popup-spec-sheet.png (obsolete) —
The preview popups in devtools (image popups and the event popup in the Inspector come to mind) could use a visual refresh. I'm attaching a spec sheet with what I think they should look like.
Attached image popup-spec-sheet.png (obsolete) —
Attachment #8732841 - Attachment is obsolete: true
Making the shadow follow the shape including the triangle arrow will require a css filter (box-shadow won't work), something like this: http://jsbin.com/nopugoqeti/edit?html,css,output
Moving this into Shared Components.  Even though it's not a new component I can't think of a better place to put it
Component: Developer Tools → Developer Tools: Shared Components
There's a good chance this will be taken care of as part of rewritting, so sooner rather than later, but I'm going to mark it as a P3 for now.
Priority: -- → P3
Whiteboard: [btpp-backlog]
Nitpick: Between number and unit there should always be a space, see https://en.wikipedia.org/wiki/Space_%28punctuation%29#Spaces_and_unit_symbols or http://tex.stackexchange.com/questions/20962/should-i-put-a-space-between-a-number-and-its-unit 

So in the screenshot (and the upcoming implementation) it should be "200 x 600 px" not "200 x 600px"
Attached image popup-spec-sheet.png
×(In reply to Jens from comment #5)
> Nitpick: Between number and unit there should always be a space, see
> https://en.wikipedia.org/wiki/
> Space_%28punctuation%29#Spaces_and_unit_symbols or
> http://tex.stackexchange.com/questions/20962/should-i-put-a-space-between-a-
> number-and-its-unit 
> 
> So in the screenshot (and the upcoming implementation) it should be "200 x
> 600 px" not "200 x 600px"

Updated the spec sheet to reflect this. Thanks!

Unicode x seen in the mockup: ×
Attachment #8732856 - Attachment is obsolete: true
Depends on: 1266450
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.