Closed Bug 1258383 Opened 4 years ago Closed 3 years ago

[Static Analysis][Uninitialized scalar field] In function MouseInput(const WidgetMouseEventBase& aMouseEvent)

Categories

(Core :: Widget, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox48 --- affected
firefox50 --- fixed

People

(Reporter: andi, Assigned: andi)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, Whiteboard: CID 1357073, tpi:-)

Attachments

(1 file)

The Static Analysis tool Coverity added that scalar field |mInputSource| is not initialized in MouseInput(const WidgetMouseEventBase& aMouseEvent).
I think it must be initialized with |aMouseEvent.inputSource|.
No response for two months from vlad. kats, would you mind taking a look?
Flags: needinfo?(bugmail.mozilla)
Comment on attachment 8732874 [details]
MozReview Request: Bug 1258383 - initialize |mInputSource| with |aMouseEvent.inputSource|. r?vladv

https://reviewboard.mozilla.org/r/41421/#review52466

LGTM, thanks!
Attachment #8732874 - Flags: review+
Flags: needinfo?(bugmail.mozilla)
Attachment #8732874 - Flags: review?(vladimir)
Flags: needinfo?(bpostelnicu)
Whiteboard: CID 1357073 → CID 1357073, tpi:-
I've just land it.
Flags: needinfo?(bpostelnicu)
Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d1679fda1a1f
initialize |mInputSource| with |aMouseEvent.inputSource|. r=kats
https://hg.mozilla.org/mozilla-central/rev/d1679fda1a1f
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.