Closed
Bug 1258383
Opened 8 years ago
Closed 8 years ago
[Static Analysis][Uninitialized scalar field] In function MouseInput(const WidgetMouseEventBase& aMouseEvent)
Categories
(Core :: Widget, defect)
Core
Widget
Tracking
()
RESOLVED
FIXED
mozilla50
People
(Reporter: andi, Assigned: andi)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, Whiteboard: CID 1357073, tpi:-)
Attachments
(1 file)
The Static Analysis tool Coverity added that scalar field |mInputSource| is not initialized in MouseInput(const WidgetMouseEventBase& aMouseEvent). I think it must be initialized with |aMouseEvent.inputSource|.
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/41421/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/41421/
Attachment #8732874 -
Flags: review?(vladimir)
Comment 2•8 years ago
|
||
No response for two months from vlad. kats, would you mind taking a look?
Flags: needinfo?(bugmail.mozilla)
Comment 3•8 years ago
|
||
Comment on attachment 8732874 [details] MozReview Request: Bug 1258383 - initialize |mInputSource| with |aMouseEvent.inputSource|. r?vladv https://reviewboard.mozilla.org/r/41421/#review52466 LGTM, thanks!
Attachment #8732874 -
Flags: review+
Updated•8 years ago
|
Flags: needinfo?(bugmail.mozilla)
Attachment #8732874 -
Flags: review?(vladimir)
Updated•8 years ago
|
Flags: needinfo?(bpostelnicu)
Whiteboard: CID 1357073 → CID 1357073, tpi:-
Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d1679fda1a1f initialize |mInputSource| with |aMouseEvent.inputSource|. r=kats
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d1679fda1a1f
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•