Closed
Bug 1258385
Opened 8 years ago
Closed 8 years ago
Improve failure messages for Wait().until() calls in Firefox Puppeteer
Categories
(Testing :: Firefox UI Tests, defect)
Testing
Firefox UI Tests
Tracking
(firefox46 fixed, firefox47 fixed, firefox48 fixed, firefox-esr45 fixed)
RESOLVED
FIXED
mozilla48
People
(Reporter: whimboo, Assigned: whimboo)
References
Details
Attachments
(1 file)
Our current calls for Wait().until() don't have set any message in case of a timeout. We should do that so we get more details in what's wrong with it. Means messages like what we have currently are not that helpful and will not allow us to star failures correctly on Treeherder:
> TimeoutException: Timed out after 5.0 seconds
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/41433/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/41433/
Attachment #8732878 -
Flags: review?(mjzffr)
Assignee | ||
Comment 2•8 years ago
|
||
Would be good to have for mozilla-central and mozilla-aurora due to spikes in timeout failures on that other branch.
status-firefox47:
--- → affected
status-firefox48:
--- → affected
Comment on attachment 8732878 [details] MozReview Request: Bug 1258385 - Improve failure messages for Wait().until() calls in Firefox Puppeteer. r?sydpolk As discussed, please ask Syd for review. Thanks!
Attachment #8732878 -
Flags: review?(mjzffr)
Assignee | ||
Comment 4•8 years ago
|
||
Comment on attachment 8732878 [details] MozReview Request: Bug 1258385 - Improve failure messages for Wait().until() calls in Firefox Puppeteer. r?sydpolk Review request updated; see interdiff: https://reviewboard.mozilla.org/r/41433/diff/1-2/
Attachment #8732878 -
Attachment description: MozReview Request: Bug 1258385 - Improve failure messages for Wait().until() calls in Firefox Puppeteer. r?maja_zf → MozReview Request: Bug 1258385 - Improve failure messages for Wait().until() calls in Firefox Puppeteer. r?sydpolk
Attachment #8732878 -
Flags: review?(spolk)
Comment 5•8 years ago
|
||
Comment on attachment 8732878 [details] MozReview Request: Bug 1258385 - Improve failure messages for Wait().until() calls in Firefox Puppeteer. r?sydpolk One important question in review comments.
Attachment #8732878 -
Flags: review?(spolk) → review-
Assignee | ||
Comment 6•8 years ago
|
||
I do not see any review comment made via mozreview. Also not sure why you set r- while questions are still open.
Flags: needinfo?(spolk)
Comment 7•8 years ago
|
||
https://reviewboard.mozilla.org/r/41433/#review37907 One question about comments. ::: testing/puppeteer/firefox/firefox_puppeteer/ui/windows.py:107 (Diff revision 2) > window = None > > + with self.marionette.using_context('chrome'): > - try: > + try: > - # Bug 1169180 - Workaround for handling newly opened chrome windows > + # Bug 1169180 - Workaround for handling newly opened chrome windows > - # Once fixed revert back to make use of self.loaded > + # Once fixed revert back to make use of self.loaded Comment seems out of date. You reverted back to make use of self.loaded with this patch.
Comment 8•8 years ago
|
||
I missed the "Publish Review" button. Sorry about the "r-"; that was a misunderstanding of workflow.
Updated•8 years ago
|
Flags: needinfo?(spolk)
Updated•8 years ago
|
Attachment #8732878 -
Flags: review- → review?(spolk)
Assignee | ||
Comment 9•8 years ago
|
||
https://reviewboard.mozilla.org/r/41433/#review37907 > Comment seems out of date. You reverted back to make use of self.loaded with this patch. There is basically no logical change in how we check for the window to be loaded. The only difference is that we now have a new method on the general `Windows` class to check for the loaded state. The call to `Wait().until()` is still in place and we should keep it here. So this review comment is just about the removal of an outdated comment. I will get it removed. Further I will move down this code block until the general checks for the window have been done. This will speed-up the execution especially in case of failures.
Assignee | ||
Comment 10•8 years ago
|
||
Comment on attachment 8732878 [details] MozReview Request: Bug 1258385 - Improve failure messages for Wait().until() calls in Firefox Puppeteer. r?sydpolk Review request updated; see interdiff: https://reviewboard.mozilla.org/r/41433/diff/2-3/
Comment 11•8 years ago
|
||
Comment on attachment 8732878 [details] MozReview Request: Bug 1258385 - Improve failure messages for Wait().until() calls in Firefox Puppeteer. r?sydpolk https://reviewboard.mozilla.org/r/41433/#review38229
Attachment #8732878 -
Flags: review?(spolk) → review+
Comment 13•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d31873cc7811
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Assignee | ||
Comment 14•8 years ago
|
||
Please backport this test-only change to mozilla-aurora.
Whiteboard: [checkin-needed-aurora]
Comment 15•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/bc8dfbb87a3e
Whiteboard: [checkin-needed-aurora]
Assignee | ||
Comment 16•8 years ago
|
||
Patch works great and gives us way more failure details. Lets also backport to beta and esr45. Thanks.
status-firefox46:
--- → affected
status-firefox-esr45:
--- → affected
Whiteboard: [checkin-needed-beta][checkin-needed-esr45]
Comment 17•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/e3d56df484a8
Whiteboard: [checkin-needed-beta][checkin-needed-esr45] → [checkin-needed-esr45]
Comment 18•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-esr45/rev/230980c12d3a
Whiteboard: [checkin-needed-esr45]
You need to log in
before you can comment on or make changes to this bug.
Description
•