Closed Bug 1258414 Opened 4 years ago Closed 4 years ago

Talos xperf parsing missing main_normal_netio counter

Categories

(Testing :: Talos, defect)

defect
Not set

Tracking

(firefox47 fixed, firefox48 fixed)

RESOLVED FIXED
mozilla48
Tracking Status
firefox47 --- fixed
firefox48 --- fixed

People

(Reporter: mcmanus, Assigned: mcmanus)

References

Details

Attachments

(1 file)

See https://bugzilla.mozilla.org/show_bug.cgi?id=698882#c96

The patch in bug 698882 causes an xperf counter to disappear (yea!)
20:06:38     INFO -  COUNTER 'main_normal_netio': []

which in turn makes talos throw an error (boo!)

 20:08:48    ERROR -  Traceback (most recent call last):
 20:08:48     INFO -    File "C:\slave\test\build\tests\talos\talos\run_tests.py", line 241, in <module>
 20:08:48     INFO -      main()
 20:08:48     INFO -    File "C:\slave\test\build\tests\talos\talos\run_tests.py", line 237, in main
 20:08:48     INFO -      sys.exit(run_tests(config, browser_config))
 20:08:48     INFO -    File "C:\slave\test\build\tests\talos\talos\run_tests.py", line 222, in run_tests
 20:08:48     INFO -      talos_results.output(results_urls)
 20:08:48     INFO -    File "C:\slave\test\build\tests\talos\talos\results.py", line 62, in output
 20:08:48     INFO -      results = _output()
 20:08:48     INFO -    File "C:\slave\test\build\tests\talos\talos\output.py", line 263, in __call__
 20:08:48     INFO -      subtest['value'] = vals[0]
 20:08:48     INFO -  IndexError: list index out of range
20:08:48 ERROR - Return code: 1

I'm pretty keen on landing 698882 so if this patch (or something else that gets this running) can be reviewed quickly I'd appreciate it. The patch just leaves the counter at 0.

This is a try run with both this patch and 698882 applied
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b6d0c6993ab0&selectedJob=18351456
Comment on attachment 8732895 [details] [diff] [review]
Talos xperf parsing missing main_normal_netio counter

Review of attachment 8732895 [details] [diff] [review]:
-----------------------------------------------------------------

good find, simple fix!
Attachment #8732895 - Flags: review?(jmaher) → review+
thanks!
https://hg.mozilla.org/mozilla-central/rev/48cad6c17a8a
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Comment on attachment 8732895 [details] [diff] [review]
Talos xperf parsing missing main_normal_netio counter

Approval Request Comment
[Feature/regressing bug #]:Needed for bug 698882
[User impact if declined]: This is only fix in our tests not in the code.
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: none
[String/UUID change made/needed]: none
Attachment #8732895 - Flags: approval-mozilla-aurora?
Comment on attachment 8732895 [details] [diff] [review]
Talos xperf parsing missing main_normal_netio counter

Hi Dragana, test related changes are auto-approved and do not need to be reviewed by release management.
Flags: needinfo?(dd.mozilla)
Attachment #8732895 - Flags: approval-mozilla-aurora?
(In reply to Ritu Kothari (:ritu) from comment #7)
> Comment on attachment 8732895 [details] [diff] [review]
> Talos xperf parsing missing main_normal_netio counter
> 
> Hi Dragana, test related changes are auto-approved and do not need to be
> reviewed by release management.

Thank. Sorry, I did not know that.
Flags: needinfo?(dd.mozilla)
You need to log in before you can comment on or make changes to this bug.