Closed Bug 1258435 Opened 10 years ago Closed 10 years ago

Probably remove CacheFileIOManager::IsOnIOThreadOrCeased

Categories

(Core :: Networking: Cache, defect)

Product:
Core
Component:
Networking: Cache
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WONTFIX
Tracking Flags:
Tracking Status
firefox48 --- affected

People

(Reporter: mayhemer, Assigned: mayhemer)

Details

(Whiteboard: [necko-active])

I personally believe we no longer need the "OrCeased" functionality anymore (added in bug 945945). The check used to be there because we nullified gInstance of CacheFileIOManager before we let the IO thread finish its job. However, bug 949250 swapped the order: gInstance is nullified after the IO thread is joined.
Honza - not sure if you're actively working on this or not. If you are, please update whiteboard as appropriate :)
Whiteboard: [necko-backlog]
Assignee: nobody → honzab.moz
Status: NEW → ASSIGNED
Whiteboard: [necko-backlog] → [necko-active]
Apparently we can't do that: > xul.dll!mozilla::net::CacheFileHandle::Release() Line 92 C++ xul.dll!mozilla::RefPtrTraits<mozilla::net::CacheFileHandle>::Release(0x06c327c0) Line 40 C++ xul.dll!RefPtr<mozilla::net::CacheFileHandle>::ConstRemovingRefPtrTraits<mozilla::net::CacheFileHandle>::Release(0x06c327c0) Line 377 C++ xul.dll!RefPtr<mozilla::net::CacheFileHandle>::~RefPtr<mozilla::net::CacheFileHandle>() Line 77 C++ xul.dll!mozilla::net::CacheFileMetadata::~CacheFileMetadata() Line 146 C++ xul.dll!mozilla::net::CacheFileMetadata::`scalar deleting destructor'() C++ xul.dll!mozilla::net::CacheFileMetadata::Release() Line 40 C++ xul.dll!mozilla::RefPtrTraits<mozilla::net::CacheFileMetadata>::Release(0x0691ac80) Line 40 C++ xul.dll!RefPtr<mozilla::net::CacheFileMetadata>::ConstRemovingRefPtrTraits<mozilla::net::CacheFileMetadata>::Release(0x0691ac80) Line 377 C++ xul.dll!RefPtr<mozilla::net::CacheFileMetadata>::~RefPtr<mozilla::net::CacheFileMetadata>() Line 77 C++ xul.dll!mozilla::net::CacheFile::~CacheFile() Line 212 C++ xul.dll!mozilla::net::CacheFile::`scalar deleting destructor'() C++ xul.dll!mozilla::net::CacheFile::Release() Line 172 C++ xul.dll!mozilla::RefPtrTraits<mozilla::net::CacheFile>::Release(0x02848a20) Line 40 C++ xul.dll!RefPtr<mozilla::net::CacheFile>::ConstRemovingRefPtrTraits<mozilla::net::CacheFile>::Release(0x02848a20) Line 377 C++ xul.dll!RefPtr<mozilla::net::CacheFile>::~RefPtr<mozilla::net::CacheFile>() Line 77 C++ xul.dll!mozilla::net::CacheFileAutoLock::~CacheFileAutoLock() Line 227 C++ xul.dll!mozilla::net::CacheFile::RemoveInput(0x06c3d290, NS_BASE_STREAM_CLOSED) Line 1620 C++ xul.dll!mozilla::net::CacheFileInputStream::Release() Line 34 C++ xul.dll!nsCOMPtr_base::~nsCOMPtr_base() Line 297 C++ xul.dll!nsCOMPtr<nsISupports>::~nsCOMPtr<nsISupports>() C++ xul.dll!nsCOMPtr<nsISupports>::`scalar deleting destructor'() C++ xul.dll!mozilla::SegmentedVector<nsCOMPtr<nsISupports>,4096,mozilla::MallocAllocPolicy>::SegmentImpl<1020>::~SegmentImpl<1020>() Line 66 C++ xul.dll!mozilla::SegmentedVector<nsCOMPtr<nsISupports>,4096,mozilla::MallocAllocPolicy>::SegmentImpl<1020>::`scalar deleting destructor'() C++ xul.dll!mozilla::SegmentedVector<nsCOMPtr<nsISupports>,4096,mozilla::MallocAllocPolicy>::PopLastN(821) Line 250 C++ xul.dll!mozilla::dom::DeferredFinalizerImpl<nsISupports>::DeferredFinalize(821, 0x028ffad0) Line 2900 C++ xul.dll!mozilla::IncrementalFinalizeRunnable::ReleaseNow(false) Line 1502 C++ xul.dll!mozilla::CycleCollectedJSRuntime::FinalizeDeferredThings(FinalizeNow) Line 1576 C++ xul.dll!mozilla::CycleCollectedJSRuntime::OnGC(JSGC_END) Line 1622 C++ xul.dll!mozilla::CycleCollectedJSRuntime::GCCallback(0x0370d000, JSGC_END, 0x02855800) Line 797 C++ xul.dll!js::gc::GCRuntime::callGCCallback(JSGC_END) Line 1683 C++ xul.dll!`anonymous namespace'::AutoNotifyGCActivity::~AutoNotifyGCActivity() Line 1715 C++ xul.dll!js::gc::GCRuntime::gcCycle(true, {...}, API) Line 6550 C++ xul.dll!js::gc::GCRuntime::collect(true, {...}, API) Line 6637 C++ xul.dll!js::gc::GCRuntime::gc(GC_NORMAL, API) Line 6698 C++ xul.dll!JS_GC(0x0370d000) Line 1397 C++ xul.dll!XRE_XPCShellMain(26, 0x0280ecfc, 0x011743c0, 0x0018fa94) Line 1606 C++ xpcshell.exe!NS_internal_main(33, 0x0280ece0, 0x011743c0) Line 62 C++ xpcshell.exe!wmain(33, 0x0117d640) Line 127 C++ The IO thread is ceased at this time.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.