If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Add READ_EXTERNAL_STORAGE permission to Fennec

RESOLVED FIXED in Firefox 48

Status

()

Firefox for Android
General
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: nalexander, Assigned: nalexander)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 48
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox48 fixed)

Details

(Assignee)

Description

2 years ago
sebastian reviewed this tiny patch in https://bugzilla.mozilla.org/show_bug.cgi?id=1254353#c9.  That ticket is lagging so landing here.
(Assignee)

Comment 1

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/91736cfdc9b0128cf40a779163d3fa244dcac933
Bug 1258452 - Pre: Assemble app and tests when collecting dependencies. r=me

https://hg.mozilla.org/integration/fx-team/rev/a42ef90399bd6a848fb839647ea328e9453ffe5f
Bug 1258452 - Explicitly request READ_EXTERNAL_STORAGE permission. r=sebastian

Comment 2

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/91736cfdc9b0
https://hg.mozilla.org/mozilla-central/rev/a42ef90399bd
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48

Comment 3

2 years ago
Is this going to result in a permissions bump for users?
Flags: needinfo?(nalexander)
(Assignee)

Comment 4

2 years ago
(In reply to :Margaret Leibovic from comment #3)
> Is this going to result in a permissions bump for users?

To the best of my knowledge, no.  READ_EXTERNAL_STORAGE is considered "dangerous", per Android: https://developer.android.com/reference/android/Manifest.permission.html#READ_EXTERNAL_STORAGE; but it's *implicitly* granted if you request WRITE_EXTERNAL_STORAGE, which we do.  This patch just *explicitly* asks for the permission, to work around a weirdness in the Android toolchain where the permission isn't always implicitly granted in the bouncer APK.

So we always have this permission (implicitly granted) in Fennec proper; this adds it to the bouncer.
Flags: needinfo?(nalexander)
You need to log in before you can comment on or make changes to this bug.