Closed
Bug 1258459
Opened 8 years ago
Closed 8 years ago
Fix TalosPowersContent forceCCAndGC handler to not expect "name" in event detail
Categories
(Testing :: Talos, defect)
Testing
Talos
Tracking
(firefox48 fixed)
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: mconley, Unassigned)
Details
Attachments
(1 file)
I'm afraid to say that the forceCC and forceGC stuff I added late last week is not working; the code is slightly broken. Here's the broken bit: https://dxr.mozilla.org/mozilla-central/source/testing/talos/talos/talos-powers/chrome/talos-powers-content.js#48 There's this fragment from an earlier revision of this patch that is making reference to a "name" on the detail of the event. But the event detail is null, so name doesn't exist, so the event handler throws. This doesn't cause the test to fail, but it also means we don't CC / GC, so this is basically a no-op. https://treeherder.mozilla.org/perf.html#/compare?originalProject=mozilla-inbound&originalRevision=58dc7aaefa9c&newProject=try&newRevision=9b3376e7c20e&framework=1 Strangely, fixing this seems to regress Linux 64 tpaint non-e10s, so I'll try to sort that out before requesting review.
Reporter | ||
Comment 1•8 years ago
|
||
Try pushes to gather profiles With patch applied: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1cf4691e20ed Without patch applied: https://treeherder.mozilla.org/#/jobs?repo=try&revision=269202e3c13b
Reporter | ||
Updated•8 years ago
|
Flags: needinfo?(mconley)
Comment 2•8 years ago
|
||
nice find!
Reporter | ||
Comment 3•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/41767/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/41767/
Attachment #8733410 -
Flags: review?(jmaher)
Updated•8 years ago
|
Attachment #8733410 -
Flags: review?(jmaher) → review+
Comment 4•8 years ago
|
||
Comment on attachment 8733410 [details] MozReview Request: Bug 1258459 - Fix TalosPowersContent forceCCAndGC handler to not expect "name" in event detail. Also do shrinking GC. r?jmaher https://reviewboard.mozilla.org/r/41767/#review38155 thanks for updating this!
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/49db4760ede4
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•