Status

()

defect
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: dvander, Assigned: dvander)

Tracking

unspecified
mozilla48
Points:
---

Firefox Tracking Flags

(firefox48 fixed)

Details

Attachments

(2 attachments)

PCompositor is a confusing name since it has very little relation to Compositor. It's more related to the function ImageBridge serves, so Matt suggested renaming it to PCompositorBridge.

This would leave us with CompositorBridgeParent and CompositorBridgeChild.

Any objections?
Attachment #8733177 - Flags: review?(matt.woodrow) → review+
Attachment #8733178 - Flags: review?(matt.woodrow) → review+
https://hg.mozilla.org/mozilla-central/rev/92ece637da91
https://hg.mozilla.org/mozilla-central/rev/4f1482e6da91
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Could you update the Crash Signature field on the open bugs with a matching name please?
https://bugzilla.mozilla.org/buglist.cgi?f1=cf_crash_signature&o1=substring&resolution=---&chfieldto=Now&query_format=advanced&chfield=cf_crash_signature&v1=PCompositor
(keep the old signature, add a copy with the new naming scheme)
Flags: needinfo?(dvander)
(In reply to Mats Palmgren (:mats) from comment #5)
> Could you update the Crash Signature field on the open bugs with a matching
> name please?
> https://bugzilla.mozilla.org/buglist.
> cgi?f1=cf_crash_signature&o1=substring&resolution=---
> &chfieldto=Now&query_format=advanced&chfield=cf_crash_signature&v1=PComposito
> r
> (keep the old signature, add a copy with the new naming scheme)

Add a copy?
Flags: needinfo?(dvander)
Sorry, what I meant is something like this, for each bug:
* copy the text from the Crash Signature field into a text editor
* search+replace PCompositor -> PCompositorBridge (or what is appropriate)
* append that text to the existing signatures in the Crash Signature field

IOW, make sure the Crash Signature fields for the bugs above have both the old
signatures and the (expected) new signatures, so that both old and new crash
reports on https://crash-stats.mozilla.com/ will match and be linked to the bug.
Flags: needinfo?(dvander)
Flags: needinfo?(dvander)
You need to log in before you can comment on or make changes to this bug.