Closed Bug 1258481 Opened 8 years ago Closed 8 years ago

Add a RegionBuilder for accumulating rects

Categories

(Core :: Graphics, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: BenWa, Unassigned)

References

(Blocks 2 open bugs)

Details

(Keywords: feature, Whiteboard: [gfx-noted])

Attachments

(2 files)

In bug 1248044 we discussed adding a RegionBuilder. Splitting this off here.
Comment on attachment 8733040 [details]
MozReview Request: Bug 1258481 - Add a RegionBuilder for accumulating rects. r=jrmuizel

https://reviewboard.mozilla.org/r/41529/#review37955
Attachment #8733040 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8733041 [details]
MozReview Request: Bug 1258481 - Use RegionBuilder for nsRegion IPC. r=jrmuizel

https://reviewboard.mozilla.org/r/41523/#review37957

::: gfx/ipc/GfxMessageUtils.h:27
(Diff revision 1)
> -#include "FilterSupport.h"
>  #include "mozilla/layers/GeckoContentController.h"
> +#include "mozilla/layers/LayersTypes.h"
> +#include "nsRect.h"
> +#include "nsRegion.h"
> +

I assume all of the include changes make sense.
Attachment #8733041 - Flags: review?(jmuizelaar) → review+
I just did vim ':sort' on them since they were a mess.
Keywords: feature
OS: Unspecified → All
Hardware: Unspecified → All
Whiteboard: [gfx-noted]
Version: unspecified → Trunk
Comment on attachment 8733041 [details]
MozReview Request: Bug 1258481 - Use RegionBuilder for nsRegion IPC. r=jrmuizel

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/41523/diff/1-2/
Had a simple logic error in the IPC code. ni? for landing after try.
Flags: needinfo?(bgirard)
Comment on attachment 8733041 [details]
MozReview Request: Bug 1258481 - Use RegionBuilder for nsRegion IPC. r=jrmuizel

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/41523/diff/2-3/
Comment on attachment 8733040 [details]
MozReview Request: Bug 1258481 - Add a RegionBuilder for accumulating rects. r=jrmuizel

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/41529/diff/1-2/
Comment on attachment 8733041 [details]
MozReview Request: Bug 1258481 - Use RegionBuilder for nsRegion IPC. r=jrmuizel

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/41523/diff/3-4/
Flags: needinfo?(bgirard)
https://hg.mozilla.org/mozilla-central/rev/89d767660c10
https://hg.mozilla.org/mozilla-central/rev/fea97c450559
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Benoit, is this something manual QA should be looking into for Fx48? If that's the case, could you please expand a bit on what should we focus on while testing this feature?
Flags: qe-verify?
Flags: needinfo?(bgirard)
No need. This is a low level change covered by unit tests.
Flags: needinfo?(bgirard)
(In reply to Benoit Girard (:BenWa) from comment #17)
> No need. This is a low level change covered by unit tests.

Thank you for following up on this!
Flags: qe-verify? → qe-verify-
I had a quick look and this way of region building is still O(n^2), more precisely it's at least O(numOfXYBands * numRects).
You need to log in before you can comment on or make changes to this bug.