Closed
Bug 1258501
Opened 8 years ago
Closed 8 years ago
Color swatches are misaligned with the value it represents
Categories
(DevTools :: Inspector, enhancement, P3)
DevTools
Inspector
Tracking
(firefox48 fixed)
RESOLVED
FIXED
Firefox 48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: nchevobbe)
Details
(Whiteboard: [btpp-backlog])
Attachments
(2 files)
38.62 KB,
image/png
|
hholmes
:
ui-review+
|
Details |
58 bytes,
text/x-review-board-request
|
miker
:
review+
|
Details |
The color swatches ( and the other swatches as well - filter, bezier, ... ) seems slightly too low compared to the value
Assignee | ||
Comment 1•8 years ago
|
||
Shows the problem and a proposed fix ( margin-top : -1px on the swatch )
Assignee: nobody → chevobbe.nicolas
Flags: needinfo?(hholmes)
Attachment #8733021 -
Flags: feedback?(hholmes)
Updated•8 years ago
|
Component: Developer Tools → Developer Tools: Inspector
Product: Developer Documentation → Firefox
Comment 2•8 years ago
|
||
Triaging (filter on CLIMBING SHOES)
Priority: -- → P3
Whiteboard: [btpp-backlog]
Comment 3•8 years ago
|
||
Comment on attachment 8733021 [details]
swatch offset
This change looks good to me! +1
Flags: needinfo?(hholmes)
Attachment #8733021 -
Flags: feedback?(hholmes) → ui-review+
Assignee | ||
Comment 4•8 years ago
|
||
Add a negative top offset to align swatches ( color, filter, bezier, ...) with the values they represent. Review commit: https://reviewboard.mozilla.org/r/41941/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/41941/
Attachment #8733752 -
Flags: review?(mratcliffe)
Comment on attachment 8733752 [details] MozReview Request: Bug 1258501 - Better swatch alignement in the rules view. r=miker https://reviewboard.mozilla.org/r/41941/#review38415
Attachment #8733752 -
Flags: review?(mratcliffe) → review+
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 6•8 years ago
|
||
Waiting for https://treeherder.mozilla.org/#/jobs?repo=try&revision=b730c60563cf
Keywords: checkin-needed
Assignee | ||
Comment 7•8 years ago
|
||
try run is over and everything is fine (https://treeherder.mozilla.org/#/jobs?repo=try&revision=b730c60563cf&selectedJob=18548155 is a known issue : Bug 1254746 )
Keywords: checkin-needed
Assignee | ||
Comment 8•8 years ago
|
||
Comment on attachment 8733752 [details] MozReview Request: Bug 1258501 - Better swatch alignement in the rules view. r=miker Review request updated; see interdiff: https://reviewboard.mozilla.org/r/41941/diff/1-2/
Assignee | ||
Comment 9•8 years ago
|
||
(In reply to Nicolas Chevobbe from comment #8) > Comment on attachment 8733752 [details] > MozReview Request: Bug 1258501 - Better swatch alignement in the rules view. > r=miker > > Review request updated; see interdiff: > https://reviewboard.mozilla.org/r/41941/diff/1-2/ Rebase
Comment 10•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/2bac6e929e8f
Keywords: checkin-needed
Comment 11•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2bac6e929e8f
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•