Closed Bug 1258501 Opened 4 years ago Closed 4 years ago

Color swatches are misaligned with the value it represents

Categories

(DevTools :: Inspector, enhancement, P3)

enhancement

Tracking

(firefox48 fixed)

RESOLVED FIXED
Firefox 48
Tracking Status
firefox48 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

Details

(Whiteboard: [btpp-backlog])

Attachments

(2 files)

The color swatches ( and the other swatches as well - filter, bezier, ... ) seems slightly too low compared to the value
Attached image swatch offset
Shows the problem and a proposed fix ( margin-top : -1px on the swatch )
Assignee: nobody → chevobbe.nicolas
Flags: needinfo?(hholmes)
Attachment #8733021 - Flags: feedback?(hholmes)
Component: Developer Tools → Developer Tools: Inspector
Product: Developer Documentation → Firefox
Triaging (filter on CLIMBING SHOES)
Priority: -- → P3
Whiteboard: [btpp-backlog]
Comment on attachment 8733021 [details]
swatch offset

This change looks good to me! +1
Flags: needinfo?(hholmes)
Attachment #8733021 - Flags: feedback?(hholmes) → ui-review+
Add a negative top offset to align swatches ( color, filter, bezier, ...) with
the values they represent.

Review commit: https://reviewboard.mozilla.org/r/41941/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/41941/
Attachment #8733752 - Flags: review?(mratcliffe)
Comment on attachment 8733752 [details]
MozReview Request: Bug 1258501 - Better swatch alignement in the rules view. r=miker

https://reviewboard.mozilla.org/r/41941/#review38415
Attachment #8733752 - Flags: review?(mratcliffe) → review+
Keywords: checkin-needed
Comment on attachment 8733752 [details]
MozReview Request: Bug 1258501 - Better swatch alignement in the rules view. r=miker

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/41941/diff/1-2/
(In reply to Nicolas Chevobbe from comment #8)
> Comment on attachment 8733752 [details]
> MozReview Request: Bug 1258501 - Better swatch alignement in the rules view.
> r=miker
> 
> Review request updated; see interdiff:
> https://reviewboard.mozilla.org/r/41941/diff/1-2/

Rebase
https://hg.mozilla.org/mozilla-central/rev/2bac6e929e8f
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.