testRotationAndDeleteShowsCorrectTile() does a lot of work to populate Top Sites: it loads a bunch of actual top site domains individually, then rotates and deletes some of the sites. It doesn't actually verify the results after any of these actions, though; the only actual assertion is at the end, where we verify that the last cell is not a suggested site (?) We should make this test more focused so that it's clear what it should actually be testing, and then have it test those conditions. Alternatively, we could just delete the test.
Assignee: nobody → sleroux
Status: NEW → ASSIGNED
Created attachment 8745507 [details] [review] Github PR https://github.com/mozilla/firefox-ios/pull/1744 Fixes this and other related Top Sites issues we're seeing on master.
Attachment #8745507 - Flags: review?(bnicholson)
Comment on attachment 8745507 [details] [review] Github PR https://github.com/mozilla/firefox-ios/pull/1744 Looks good, just questions about where we want to define strings and a few other minor things.
Attachment #8745507 - Flags: review?(bnicholson) → review+
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-fxios-v5.0: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.