testRotationAndDeleteShowsCorrectTile doesn't test anything useful

RESOLVED FIXED

Status

()

RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: bnicholson, Assigned: sleroux)

Tracking

unspecified
All
iOS

Firefox Tracking Flags

(fxios-v5.0 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
testRotationAndDeleteShowsCorrectTile() does a lot of work to populate Top Sites: it loads a bunch of actual top site domains individually, then rotates and deletes some of the sites. It doesn't actually verify the results after any of these actions, though; the only actual assertion is at the end, where we verify that the last cell is not a suggested site (?)

We should make this test more focused so that it's clear what it should actually be testing, and then have it test those conditions. Alternatively, we could just delete the test.
(Assignee)

Updated

3 years ago
Assignee: nobody → sleroux
Status: NEW → ASSIGNED
(Assignee)

Comment 1

2 years ago
Created attachment 8745507 [details] [review]
Github PR https://github.com/mozilla/firefox-ios/pull/1744

Fixes this and other related Top Sites issues we're seeing on master.
Attachment #8745507 - Flags: review?(bnicholson)
(Reporter)

Comment 2

2 years ago
Comment on attachment 8745507 [details] [review]
Github PR https://github.com/mozilla/firefox-ios/pull/1744

Looks good, just questions about where we want to define strings and a few other minor things.
Attachment #8745507 - Flags: review?(bnicholson) → review+
(Assignee)

Comment 3

2 years ago
master 8b9634067f5a4cfd2b85f341e522787fff470c07
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-fxios-v5.0: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.