Closed
Bug 1258578
Opened 8 years ago
Closed 8 years ago
Comments on js::RelocatablePtr are unclear
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: jimb, Assigned: jimb)
Details
Attachments
(1 file)
2.32 KB,
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
The comments for js::RelocatablePtr are unclear on exactly what is relocatable, and why. In a moving GC, there are so many things being moved around that the word "relocatable" itself doesn't tell the story. Included is a doc patch that hopefully spells things out a little better.
Attachment #8733139 -
Flags: review?(terrence)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → jimb
Comment 1•8 years ago
|
||
Comment on attachment 8733139 [details] [diff] [review] Improve documentation for js::RelocatablePtr. Review of attachment 8733139 [details] [diff] [review]: ----------------------------------------------------------------- Thanks, that's much better!
Attachment #8733139 -
Flags: review?(terrence) → review+
Assignee | ||
Updated•8 years ago
|
Flags: in-testsuite-
Target Milestone: --- → mozilla48
Comment 3•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/cbbc3c971d80
You need to log in
before you can comment on or make changes to this bug.
Description
•