security/pkix/test/gtest/pkixcheck_CheckSignatureAlgorithm_tests.cpp(231): warning C4459: declaration of 'now' hides global declaration

RESOLVED FIXED in Firefox 48

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: gps, Assigned: keeler)

Tracking

unspecified
mozilla48
Points:
---

Firefox Tracking Flags

(firefox48 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

3 years ago
This compilation is turned into an error when building with VS2015 in automation.

 16:58:04     INFO -  c:/builds/moz2_slave/try-w64-d-00000000000000000000/build/src/security/pkix/test/gtest/pkixcheck_CheckSignatureAlgorithm_tests.cpp(231): error C2220: warning treated as error - no 'object' file generated
 16:58:04     INFO -  Warning: C4459 in c:\builds\moz2_slave\try-w64-d-00000000000000000000\build\src\security\pkix\test\gtest\pkixcheck_CheckSignatureAlgorithm_tests.cpp: declaration of 'now' hides global declaration
 16:58:04     INFO -  c:/builds/moz2_slave/try-w64-d-00000000000000000000/build/src/security/pkix/test/gtest/pkixcheck_CheckSignatureAlgorithm_tests.cpp(231): warning C4459: declaration of 'now' hides global declaration
 16:58:04     INFO -  c:/builds/moz2_slave/try-w64-d-00000000000000000000/build/src/security/pkix/test/gtest/pkixcheck_CheckSignatureAlgorithm_tests.cpp(231): note: to simplify migration, consider the temporary use of /Wv:18 flag with the version of the compiler with which you used to build without warnings
 16:58:04     INFO -  c:\builds\moz2_slave\try-w64-d-00000000000000000000\build\src\security\pkix\test\gtest\pkixgtest.h(82): note: see declaration of 'mozilla::pkix::test::now'
 16:58:04     INFO -  PATH=../lib:../stubdata:../tools/ctestfw:$PATH  ../bin/genrb --usePoolBundle -kR -i ./out/build/icudt56l -s c:/builds/moz2_slave/try-w64-d-00000000000000000000/build/src/intl/icu/source/data/locales -d ./out/build/icudt56l fur.txt
 16:58:04     INFO -  c:/builds/moz2_slave/try-w64-d-00000000000000000000/build/src/config/rules.mk:918: recipe for target 'pkixcheck_CheckSignatureAlgorithm_tests.obj' failed
16:58:04 INFO - mozmake.EXE[5]: *** [pkixcheck_CheckSignatureAlgorithm_tests.obj] Error 2
(Reporter)

Comment 1

3 years ago
Warning from https://treeherder.mozilla.org/#/jobs?repo=try&revision=55be1b0189da in case the line number changes.
(Reporter)

Comment 2

3 years ago
Created attachment 8733140 [details]
MozReview Request: Bug 1258579 - Disable C4459 to unblock compilation on VS2015; r?keeler

As part of unblocking building with VS2015u1 in automation, I'm mass
disabling compiler warnings that are turned into errors. This is not
the preferred mechanism to fix compilation warnings. So hopefully
someone pushes back against this patch and fixes the underlying
warning instead.

Review commit: https://reviewboard.mozilla.org/r/41591/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/41591/
Attachment #8733140 - Flags: review?(dkeeler)

Updated

3 years ago
Component: Security → Security: PSM
Comment on attachment 8733140 [details]
MozReview Request: Bug 1258579 - Disable C4459 to unblock compilation on VS2015; r?keeler

https://reviewboard.mozilla.org/r/41591/#review38179

Yeah, we don't need to paper over this. I have a patch that should fix it.
Attachment #8733140 - Flags: review?(dkeeler)
Created attachment 8733455 [details]
MozReview Request: bug 1258579 - remove some unnecessary time-related globals from mozilla::pkix tests r?Cykesiopka

Review commit: https://reviewboard.mozilla.org/r/41783/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/41783/
Attachment #8733455 - Flags: review?(cykesiopka.bmo)
Assignee: nobody → dkeeler

Comment 5

3 years ago
Comment on attachment 8733455 [details]
MozReview Request: bug 1258579 - remove some unnecessary time-related globals from mozilla::pkix tests r?Cykesiopka

https://reviewboard.mozilla.org/r/41783/#review38237

LGTM, but you might want to get gps to do another try run with the changes here included just to confirm it works.
Attachment #8733455 - Flags: review?(cykesiopka.bmo) → review+
Comment on attachment 8733455 [details]
MozReview Request: bug 1258579 - remove some unnecessary time-related globals from mozilla::pkix tests r?Cykesiopka

Thanks for the review.
gps - does this fix it? (and not introduce new warnings?)
Attachment #8733455 - Flags: feedback?(gps)
(Reporter)

Comment 7

3 years ago
Comment on attachment 8733455 [details]
MozReview Request: bug 1258579 - remove some unnecessary time-related globals from mozilla::pkix tests r?Cykesiopka

Try push was happy. I'll land this for you.
Attachment #8733455 - Flags: feedback?(gps) → feedback+
(Reporter)

Updated

3 years ago
Attachment #8733140 - Attachment is obsolete: true

Comment 9

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/85ff16d9d6f3
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.