Make test_case_differences.html work in e10s

RESOLVED FIXED in Firefox 48

Status

()

Toolkit
Password Manager
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: MattN, Assigned: MattN)

Tracking

(Blocks: 1 bug)

unspecified
mozilla48
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(e10s+, firefox48 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

This is the first autocomplete test I'm fixing with e10s. Rather than duplicate all the e10s helpers from satchel, I plan to just reference the satchel helpers in support-files.
Created attachment 8733207 [details]
MozReview Request: Bug 1258607 - Output task names when entering and leaving in SimpleTest. r=jmaher

This uses the same text as the equivalent code in browser-test.js.

Review commit: https://reviewboard.mozilla.org/r/41643/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/41643/
Attachment #8733207 - Flags: review?(jmaher)
Created attachment 8733208 [details]
MozReview Request: Bug 1258607 - Return promises from some satchel test helpers which use callbacks. r=dolske

Review commit: https://reviewboard.mozilla.org/r/41645/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/41645/
Attachment #8733208 - Flags: review?(dolske)
Created attachment 8733209 [details]
MozReview Request: Bug 1258607 - Make test_case_differences.html work in e10s. r=dolske

Switch to add_task and use satchel helpers for autocomplete.

Review commit: https://reviewboard.mozilla.org/r/41647/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/41647/
Attachment #8733209 - Flags: review?(dolske)
Comment on attachment 8733207 [details]
MozReview Request: Bug 1258607 - Output task names when entering and leaving in SimpleTest. r=jmaher

https://reviewboard.mozilla.org/r/41643/#review38077

::: testing/mochitest/tests/SimpleTest/SpawnTask.js:276
(Diff revision 1)
>            // We stop the entire test file at the first exception because this
>            // may mean that the state of subsequent tests may be corrupt.
>            try {
>              for (var task of task_list) {
> +              var name = task.name || "";
> +              info("Entering test " + name);

I would like a bit more context so we know this is coming from SimpleTest:SpawnTask.  Do you know if there is already adequate information in the log to make these messages useful?
Attachment #8733207 - Flags: review?(jmaher)

Updated

2 years ago
tracking-e10s: ? → +
Attachment #8733207 - Flags: review?(jmaher)
Comment on attachment 8733207 [details]
MozReview Request: Bug 1258607 - Output task names when entering and leaving in SimpleTest. r=jmaher

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/41643/diff/1-2/
Comment on attachment 8733208 [details]
MozReview Request: Bug 1258607 - Return promises from some satchel test helpers which use callbacks. r=dolske

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/41645/diff/1-2/
Comment on attachment 8733209 [details]
MozReview Request: Bug 1258607 - Make test_case_differences.html work in e10s. r=dolske

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/41647/diff/1-2/
Comment on attachment 8733207 [details]
MozReview Request: Bug 1258607 - Output task names when entering and leaving in SimpleTest. r=jmaher

https://reviewboard.mozilla.org/r/41643/#review38271

thanks, this looks better.
Attachment #8733207 - Flags: review?(jmaher) → review+
Blocks: 1258860
Comment on attachment 8733209 [details]
MozReview Request: Bug 1258607 - Make test_case_differences.html work in e10s. r=dolske

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/41647/diff/2-3/
Comment on attachment 8733208 [details]
MozReview Request: Bug 1258607 - Return promises from some satchel test helpers which use callbacks. r=dolske

https://reviewboard.mozilla.org/r/41645/#review38879

Would it be worth moving the satchel tests into test-type subdirs?
Attachment #8733208 - Flags: review?(dolske) → review+
Comment on attachment 8733209 [details]
MozReview Request: Bug 1258607 - Make test_case_differences.html work in e10s. r=dolske

https://reviewboard.mozilla.org/r/41647/#review38887
Attachment #8733209 - Flags: review?(dolske) → review+

Comment 12

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/fbab845377a5
https://hg.mozilla.org/integration/fx-team/rev/e769ae36cbc7
https://hg.mozilla.org/integration/fx-team/rev/96bfe329ad1e
https://hg.mozilla.org/mozilla-central/rev/fbab845377a5
https://hg.mozilla.org/mozilla-central/rev/e769ae36cbc7
https://hg.mozilla.org/mozilla-central/rev/96bfe329ad1e
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.