Closed Bug 1258607 Opened 4 years ago Closed 4 years ago

Make test_case_differences.html work in e10s

Categories

(Toolkit :: Password Manager, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
e10s + ---
firefox48 --- fixed

People

(Reporter: MattN, Assigned: MattN)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

This is the first autocomplete test I'm fixing with e10s. Rather than duplicate all the e10s helpers from satchel, I plan to just reference the satchel helpers in support-files.
Comment on attachment 8733207 [details]
MozReview Request: Bug 1258607 - Output task names when entering and leaving in SimpleTest. r=jmaher

https://reviewboard.mozilla.org/r/41643/#review38077

::: testing/mochitest/tests/SimpleTest/SpawnTask.js:276
(Diff revision 1)
>            // We stop the entire test file at the first exception because this
>            // may mean that the state of subsequent tests may be corrupt.
>            try {
>              for (var task of task_list) {
> +              var name = task.name || "";
> +              info("Entering test " + name);

I would like a bit more context so we know this is coming from SimpleTest:SpawnTask.  Do you know if there is already adequate information in the log to make these messages useful?
Attachment #8733207 - Flags: review?(jmaher)
Comment on attachment 8733207 [details]
MozReview Request: Bug 1258607 - Output task names when entering and leaving in SimpleTest. r=jmaher

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/41643/diff/1-2/
Comment on attachment 8733208 [details]
MozReview Request: Bug 1258607 - Return promises from some satchel test helpers which use callbacks. r=dolske

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/41645/diff/1-2/
Comment on attachment 8733209 [details]
MozReview Request: Bug 1258607 - Make test_case_differences.html work in e10s. r=dolske

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/41647/diff/1-2/
Comment on attachment 8733207 [details]
MozReview Request: Bug 1258607 - Output task names when entering and leaving in SimpleTest. r=jmaher

https://reviewboard.mozilla.org/r/41643/#review38271

thanks, this looks better.
Attachment #8733207 - Flags: review?(jmaher) → review+
Comment on attachment 8733209 [details]
MozReview Request: Bug 1258607 - Make test_case_differences.html work in e10s. r=dolske

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/41647/diff/2-3/
Comment on attachment 8733208 [details]
MozReview Request: Bug 1258607 - Return promises from some satchel test helpers which use callbacks. r=dolske

https://reviewboard.mozilla.org/r/41645/#review38879

Would it be worth moving the satchel tests into test-type subdirs?
Attachment #8733208 - Flags: review?(dolske) → review+
Comment on attachment 8733209 [details]
MozReview Request: Bug 1258607 - Make test_case_differences.html work in e10s. r=dolske

https://reviewboard.mozilla.org/r/41647/#review38887
Attachment #8733209 - Flags: review?(dolske) → review+
You need to log in before you can comment on or make changes to this bug.