Closed
Bug 1258607
Opened 8 years ago
Closed 8 years ago
Make test_case_differences.html work in e10s
Categories
(Toolkit :: Password Manager, defect)
Toolkit
Password Manager
Tracking
()
RESOLVED
FIXED
mozilla48
People
(Reporter: MattN, Assigned: MattN)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
This is the first autocomplete test I'm fixing with e10s. Rather than duplicate all the e10s helpers from satchel, I plan to just reference the satchel helpers in support-files.
Assignee | ||
Comment 1•8 years ago
|
||
This uses the same text as the equivalent code in browser-test.js. Review commit: https://reviewboard.mozilla.org/r/41643/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/41643/
Attachment #8733207 -
Flags: review?(jmaher)
Assignee | ||
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/41645/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/41645/
Attachment #8733208 -
Flags: review?(dolske)
Assignee | ||
Comment 3•8 years ago
|
||
Switch to add_task and use satchel helpers for autocomplete. Review commit: https://reviewboard.mozilla.org/r/41647/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/41647/
Attachment #8733209 -
Flags: review?(dolske)
Comment 4•8 years ago
|
||
Comment on attachment 8733207 [details] MozReview Request: Bug 1258607 - Output task names when entering and leaving in SimpleTest. r=jmaher https://reviewboard.mozilla.org/r/41643/#review38077 ::: testing/mochitest/tests/SimpleTest/SpawnTask.js:276 (Diff revision 1) > // We stop the entire test file at the first exception because this > // may mean that the state of subsequent tests may be corrupt. > try { > for (var task of task_list) { > + var name = task.name || ""; > + info("Entering test " + name); I would like a bit more context so we know this is coming from SimpleTest:SpawnTask. Do you know if there is already adequate information in the log to make these messages useful?
Attachment #8733207 -
Flags: review?(jmaher)
Updated•8 years ago
|
Assignee | ||
Updated•8 years ago
|
Attachment #8733207 -
Flags: review?(jmaher)
Assignee | ||
Comment 5•8 years ago
|
||
Comment on attachment 8733207 [details] MozReview Request: Bug 1258607 - Output task names when entering and leaving in SimpleTest. r=jmaher Review request updated; see interdiff: https://reviewboard.mozilla.org/r/41643/diff/1-2/
Assignee | ||
Comment 6•8 years ago
|
||
Comment on attachment 8733208 [details] MozReview Request: Bug 1258607 - Return promises from some satchel test helpers which use callbacks. r=dolske Review request updated; see interdiff: https://reviewboard.mozilla.org/r/41645/diff/1-2/
Assignee | ||
Comment 7•8 years ago
|
||
Comment on attachment 8733209 [details] MozReview Request: Bug 1258607 - Make test_case_differences.html work in e10s. r=dolske Review request updated; see interdiff: https://reviewboard.mozilla.org/r/41647/diff/1-2/
Comment 8•8 years ago
|
||
Comment on attachment 8733207 [details] MozReview Request: Bug 1258607 - Output task names when entering and leaving in SimpleTest. r=jmaher https://reviewboard.mozilla.org/r/41643/#review38271 thanks, this looks better.
Attachment #8733207 -
Flags: review?(jmaher) → review+
Assignee | ||
Comment 9•8 years ago
|
||
Comment on attachment 8733209 [details] MozReview Request: Bug 1258607 - Make test_case_differences.html work in e10s. r=dolske Review request updated; see interdiff: https://reviewboard.mozilla.org/r/41647/diff/2-3/
Comment 10•8 years ago
|
||
Comment on attachment 8733208 [details] MozReview Request: Bug 1258607 - Return promises from some satchel test helpers which use callbacks. r=dolske https://reviewboard.mozilla.org/r/41645/#review38879 Would it be worth moving the satchel tests into test-type subdirs?
Attachment #8733208 -
Flags: review?(dolske) → review+
Comment 11•8 years ago
|
||
Comment on attachment 8733209 [details] MozReview Request: Bug 1258607 - Make test_case_differences.html work in e10s. r=dolske https://reviewboard.mozilla.org/r/41647/#review38887
Attachment #8733209 -
Flags: review?(dolske) → review+
Comment 12•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/fbab845377a5 https://hg.mozilla.org/integration/fx-team/rev/e769ae36cbc7 https://hg.mozilla.org/integration/fx-team/rev/96bfe329ad1e
Comment 13•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/fbab845377a5 https://hg.mozilla.org/mozilla-central/rev/e769ae36cbc7 https://hg.mozilla.org/mozilla-central/rev/96bfe329ad1e
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•