Closed
Bug 1258637
Opened 8 years ago
Closed 8 years ago
typo of logging of pacpNext of TSFTextStore::GetText
Categories
(Core :: Widget: Win32, defect)
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: m_kato, Unassigned)
Details
(Keywords: inputmethod, Whiteboard: [good first bug])
Attachments
(1 file)
the following pacpNext logging should be *pacpNext. STDMETHODIMP TSFTextStore::GetText(LONG acpStart, LONG acpEnd, WCHAR* pchPlain, ULONG cchPlainReq, ULONG* pcchPlainOut, TS_RUNINFO* prgRunInfo, ULONG ulRunInfoReq, ULONG* pulRunInfoOut, LONG* pacpNext) ... MOZ_LOG(sTextStoreLog, LogLevel::Info, ("TSF: 0x%p TSFTextStore::GetText() succeeded: pcchPlainOut=0x%p, " "*prgRunInfo={ uCount=%lu, type=%s }, *pulRunInfoOut=%lu, " "*pacpNext=%ld)", this, pcchPlainOut, prgRunInfo ? prgRunInfo->uCount : 0, prgRunInfo ? GetTextRunTypeName(prgRunInfo->type) : "N/A", pulRunInfoOut ? pulRunInfoOut : 0, pacpNext ? pacpNext : 0)); return S_OK; }
Reporter | ||
Updated•8 years ago
|
Whiteboard: good first bug
Reporter | ||
Updated•8 years ago
|
Whiteboard: good first bug → [good first bug]
Reporter | ||
Comment 1•8 years ago
|
||
pulRunInfoOut too...
Reporter | ||
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/43439/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/43439/
Attachment #8736592 -
Flags: review?(masayuki)
Comment 3•8 years ago
|
||
Comment on attachment 8736592 [details] MozReview Request: Bug 1258637 - Fix typo of logging of pacpNext of TSFTextStore::GetText. r?masayuki https://reviewboard.mozilla.org/r/43439/#review39999 Thanks!
Attachment #8736592 -
Flags: review?(masayuki) → review+
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c710d0da3ac1
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•