1258643 - The sub-title of 'Close Private Tabs' setting does not fit on 3.5"/4.0" devices

Status: VERIFIED FIXED

(Firefox for iOS :: General, defect)

Description

[Catalin Suciu [:csuciu]]

Attachment: Screen Shot 2016-03-22 at 11.05.07.png

v3.0b7
iPhone 4S 3.5"
iPod Touch 6th gen 4"

1. Go to Firefox settings
2. See the 'Close Private Tabs' row

Result: The sub-title does not fit the row

Comment 1

[Stephan Leroux [:sleroux]]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1654

Comment 2

[Stephan Leroux [:sleroux]]

Attachment: Simulator Screen Shot Mar 22, 2016, 12.40.46 PM.png

Here is a side effect of the changes by removing the the constraint that was causing problems. In cases where the text fits on a line without word break, it will push up right next to the switch which isn't the greatest thing in the world. I've tried today to get a fix going but coming up short.

It's been brought up before but I wonder if we should look into replacing the use of the default UITableViewCells with customizations with cell subclasses that allow us to have more control over the layout of things like labels/switch/etc. I know there were issues before with readableMargins and other finicky Autolayout stuff but might be worth investigating.

Comment 4

[Stephan Leroux [:sleroux]]

Attachment: Simulator Screen Shot Mar 22, 2016, 3.10.12 PM.png

Thanks for the padding fix Brian! Looks much better now.

Comment 5

[Stephan Leroux [:sleroux]]

master a7c2a0643289c013431878156899079a64cad9d5

Comment 6

[Catalin Suciu [:csuciu]]

All subtitles are looking good on master a6c672f
Tested on 3.5" and 4" devices.

Comment 7

[Stephan Leroux [:sleroux]]

v3.x 2e8e939

Comment 8

[Catalin Suciu [:csuciu]]

Verifying as fixed on 3.0b8