v3.0b7 iPhone 4S (9.0) 1. Visit www.mozilla.org. 2. Go to the Share Menu and open Find In Page. 4. Type 'feature' in the Find in Page bar (VKB remains open). Expected: First match is visible above the bar. Actual: First match is not visible. Scrolling down the page will reveal it.
This involves modifying Client/Assets/FindInPage.js. Currently, we center the result in the viewport, but the keyboard takes up more than half of the screen on small devices, so the result gets covered up. We can modify the scrollTo offset to be a bit higher so it's no longer hidden.
Whiteboard: [good first bug]
Created attachment 8740540 [details] [review] Pull Request
Attachment #8740540 - Flags: review?(bnicholson)
Comment on attachment 8740540 [details] [review] Pull Request Looks good! Before merging, please add Bug 1258695 - to the beginning of the commit message/PR. This makes it easier to trace back to the bug in the future when using git log or git blame.
Attachment #8740540 - Flags: review?(bnicholson) → review+
Sounds good. Thanks!
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-fxios-v5.0: --- → fixed
Resolution: --- → FIXED
Whiteboard: [good first bug] → [good first bug][needsuplift]
status-fxios-v4.0: affected → fixed
Whiteboard: [good first bug][needsuplift] → [good first bug]
Target Milestone: --- → 4.0
Verifying as fixed on 4.0.0b2 and master 14fcad7
Status: RESOLVED → VERIFIED
status-fxios-v4.0: fixed → verified
status-fxios-v5.0: fixed → verified
You need to log in before you can comment on or make changes to this bug.