1258718 - Simplify highlighters.css adding CSS variables

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P3)

Description

[Matteo Ferretti [:zer0] [:matteo]]

We can't use theme variables in highlighters.css, but we the file should be at least having it's own set of variables.

Comment 1

[Patrick Brosset <:pbro>]

Triaging (Filter on CLIMBING SHOES)

Comment 2

[Matteo Ferretti [:zer0] [:matteo]]

Attachment: MozReview Request: Bug 1258718 - Simplify highlighters.css adding CSS variables; r=pbro

Review commit: https://reviewboard.mozilla.org/r/43435/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43435/

Comment 3

[Matteo Ferretti [:zer0] [:matteo]]

Note: since this bug was filed based on Bug 1139187 comment 30, the patch is applied on top of that.

Comment 4

[Patrick Brosset <:pbro>]

Comment on attachment 8736588 [details]
MozReview Request: Bug 1258718 - Simplify highlighters.css adding CSS variables; r=pbro

https://reviewboard.mozilla.org/r/43435/#review40963

Simple enough, nice enough change for a quick R+. I've made a suggestion to define one more variable and add a border around the measurement tool bubbles.

::: devtools/server/actors/highlighters.css:20
(Diff revision 1)
>  
>  :-moz-native-anonymous .highlighter-container {
> +    --highlighter-guide-color: #08c;
> +    --highlighter-content-color: #87ceeb;
> +    --highlighter-bubble-text-color: hsl(216, 33%, 97%);
> +    --highlighter-bubble-background-color: hsl(214, 13%, 24%);

I would also add --hithlighter-bubble-border-color, and I think we should add a color around the labels displayed by the measurement tool. This way they would be easier to see over dark backgrounds.

Comment 5

[Matteo Ferretti [:zer0] [:matteo]]

Comment on attachment 8736588 [details]
MozReview Request: Bug 1258718 - Simplify highlighters.css adding CSS variables; r=pbro

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/43435/diff/1-2/

Comment 6

[Matteo Ferretti [:zer0] [:matteo]]

Comment on attachment 8736588 [details]
MozReview Request: Bug 1258718 - Simplify highlighters.css adding CSS variables; r=pbro

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/43435/diff/2-3/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/a92a2888973b
Simplify highlighters.css adding CSS variables; r=pbro

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a92a2888973b

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a92a2888973b