Closed
Bug 1258718
Opened 9 years ago
Closed 9 years ago
Simplify highlighters.css adding CSS variables
Categories
(DevTools :: Inspector, defect, P3)
DevTools
Inspector
Tracking
(firefox49 fixed)
RESOLVED
FIXED
Firefox 49
Tracking | Status | |
---|---|---|
firefox49 | --- | fixed |
People
(Reporter: zer0, Assigned: zer0)
References
Details
(Whiteboard: [btpp-backlog])
Attachments
(1 file)
We can't use theme variables in highlighters.css, but we the file should be at least having it's own set of variables.
Comment 1•9 years ago
|
||
Triaging (Filter on CLIMBING SHOES)
Priority: -- → P3
Whiteboard: [btpp-backlog]
Assignee | ||
Comment 2•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/43435/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43435/
Attachment #8736588 -
Flags: review?(pbrosset)
Assignee | ||
Comment 3•9 years ago
|
||
Note: since this bug was filed based on Bug 1139187 comment 30, the patch is applied on top of that.
Depends on: 1139187
Comment 4•9 years ago
|
||
Comment on attachment 8736588 [details]
MozReview Request: Bug 1258718 - Simplify highlighters.css adding CSS variables; r=pbro
https://reviewboard.mozilla.org/r/43435/#review40963
Simple enough, nice enough change for a quick R+. I've made a suggestion to define one more variable and add a border around the measurement tool bubbles.
::: devtools/server/actors/highlighters.css:20
(Diff revision 1)
>
> :-moz-native-anonymous .highlighter-container {
> + --highlighter-guide-color: #08c;
> + --highlighter-content-color: #87ceeb;
> + --highlighter-bubble-text-color: hsl(216, 33%, 97%);
> + --highlighter-bubble-background-color: hsl(214, 13%, 24%);
I would also add --hithlighter-bubble-border-color, and I think we should add a color around the labels displayed by the measurement tool. This way they would be easier to see over dark backgrounds.
Attachment #8736588 -
Flags: review?(pbrosset) → review+
Assignee | ||
Comment 5•9 years ago
|
||
Comment on attachment 8736588 [details]
MozReview Request: Bug 1258718 - Simplify highlighters.css adding CSS variables; r=pbro
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/43435/diff/1-2/
Assignee | ||
Comment 6•9 years ago
|
||
Comment on attachment 8736588 [details]
MozReview Request: Bug 1258718 - Simplify highlighters.css adding CSS variables; r=pbro
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/43435/diff/2-3/
Pushed by mferretti@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/a92a2888973b
Simplify highlighters.css adding CSS variables; r=pbro
Comment 8•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Comment 9•9 years ago
|
||
bugherder |
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•