If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Devtools Toolbox doesn't change title when attached frame changes (displays old title)

NEW
Unassigned

Status

()

Firefox
Developer Tools: Framework
P3
enhancement
2 years ago
2 years ago

People

(Reporter: arni2033, Unassigned)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(firefox48 affected)

Details

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
not-entirely-accurate
>>>   My Info:   Win7_64, Nightly 48, 32bit, ID 20160320030409
STR:
1. Open devtools -> Options, enable chrome debugging and remote debugging
2. Open http://example.org/ in a new tab
3. Open Browser Toolbox for the current window
4. Select "http://example.org/" frame

AR:  Toolbox's title says "chrome://browser/content/browser.xul"
ER:  Toolbox should have relevant title ("http://example.org/")
Comment hidden (spam)
It's not clear to me what the correct behavior here is.  We are changing a frame, which does change the debugging window so in that context it makes sense the title should change.  But on the OTOH the toolbox is still 'attached' to the process so maybe it should still say browser.xul.

Also we should note that this behavior will also affect the header on detached toolboxes on web pages with iframes targeted.
Severity: normal → enhancement
Priority: -- → P3
(Reporter)

Comment 3

2 years ago
str
(In reply to Brian Grinstead [:bgrins] from comment #2)
> It's not clear to me what the correct behavior here is.
No, it's pretty clear. Attached image contains another STR (harder) involving another window. Though
I can't see why "process" matters. Probably you meant "window"? Also, there's STR_3 showing that this issue is more common and that it's a clear breakage (maybe a duplicate, but not enhancement)


STR_2:
1. In current Firefox window, open devtools -> Options, enable chrome debugging and remote debugging
2. Open Scratchpad (Shift+F4), then focus the window from Step 1
3. Open Browser Toolbox for the current Firefox window
4. Select Scratchpad frame ("chrome://devtools/content/scratchpad/scratchpad.xul")

AR:  Toolbox's title says "chrome://browser/content/browser.xul"
ER:  Toolbox should have relevant title ("chrome://devtools/content/scratchpad/scratchpad.xul")


STR_3:
1. In current Firefox window, open http://example.org/ in a new tab
2. Open devtools -> Inspector, detach it to a separate window
3. Switch to the tab from Step 1, paste http://yandex.ru/ in urlbar, press Enter
4. Switch to devtools toolbox

AR:  Toolbox's title says "Inspector - Example Domain"
ER:  Toolbox should have relevant title ("Inspector - Яндекс")
Summary: Browser Toolbox displays incorrect title (that isn't connected to current frame) → Devtools Toolbox doesn't change title when attached frame changes (displays old title)
(In reply to arni2033 from comment #3)
> STR_3:
> 1. In current Firefox window, open http://example.org/ in a new tab
> 2. Open devtools -> Inspector, detach it to a separate window
> 3. Switch to the tab from Step 1, paste http://yandex.ru/ in urlbar, press
> Enter
> 4. Switch to devtools toolbox
> 
> AR:  Toolbox's title says "Inspector - Example Domain"
> ER:  Toolbox should have relevant title ("Inspector - Яндекс")

The reason the behavior isn't super clear to me is that the toolbox still 'belongs' to the original tab.  So if you were looking through a set of detached toolboxes for one that is debugging a certain tab then you might be looking for the URL of the tab in the taskbar, alt+tab, etc.
(Reporter)

Comment 5

2 years ago
> the toolbox still 'belongs' to the original tab
I finally got it: you're describing the case when (e.g.) normal Inspector is used to inspect iframe on the page, but it's attached to the whole tab, so it should show something related to the tab...
That case is not clear for me too.
Probably title should only display tool's name   [OR]   «top frame»'s url   [OR]
a sequence like  "[top_frame] -> [inner_frame_1] ... -> [inner_frame_N]"

Still in scenarios [2] and [3] in comment 3 toolbox's title is completely unrelated to a tab/window
(Reporter)

Updated

2 years ago
See Also: → bug 1260359
(Reporter)

Comment 6

2 years ago
@ :bgrins
Nobody had any doubts in (duplicate) bug 1260359...
Are you going go leave this bug open for discussion what title should be displayed in case frame is selected or open a separate bug for this (or maybe no discussion is needed)?
The goal of Bug 1260359 was only to fix an e10s-only bug: update the title of the devtools window when the linked browser navigates.

The fact it also updates the title when switching frame was not actually unexpected (sorry!).
I also think the behavior could be misleading for the user. And comment 5 hints at a good solution.

Let's keep this bug open to discuss it. In the meantime  I will submit a follow up to avoid updating the title when selecting the frame.
... "was not actually unexpected" -> "was actually unexpected"
Depends on: 1261687
You need to log in before you can comment on or make changes to this bug.