1258794 - Add checkstyle check for excess whitespace

Status: RESOLVED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

I don't see a specific check for it in this list of whitespace:
  http://checkstyle.sourceforge.net/config_whitespace.html

[1] indicates we may have to use RegexSingleLine*:
  http://checkstyle.sourceforge.net/config_regexp.html

This is the other most common style issue I see in reviews (along with bug 1258789).

[1]: https://stackoverflow.com/questions/15950671/eclipse-checkstyle-disable-lline-has-trailing-spaces

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1258794 - Pre: Add GenericWhitespace and fix single issue. r=nalexander

Review commit: https://reviewboard.mozilla.org/r/44627/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/44627/

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1258794 - Add excess whitespace checkstyle check & fix issues. r=nalexander

Review commit: https://reviewboard.mozilla.org/r/44629/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/44629/

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8738631 [details]
MozReview Request: Bug 1258794 - Add excess whitespace checkstyle check & fix issues. r=nalexander

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/44629/diff/1-2/

Comment 4

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8738630 [details]
MozReview Request: Bug 1258794 - Pre: Add GenericWhitespace and fix single issue. r=nalexander

https://reviewboard.mozilla.org/r/44627/#review41331

wfm.

Comment 5

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8738631 [details]
MozReview Request: Bug 1258794 - Add excess whitespace checkstyle check & fix issues. r=nalexander

https://reviewboard.mozilla.org/r/44629/#review41333

Stamp!

::: mobile/android/app/checkstyle.xml:43
(Diff revision 2)
>      <module name="FileTabCharacter"> <!-- No tabs! -->
>          <property name="eachLine" value="true"/>
>      </module>
> +    <module name="RegexpSingleline"> <!-- excess whitespace -->
> +        <property name="format" value="\s+$"/>
> +        <property name="message" value="Excess whitespace at end of line"/>

Generally we call this "trailing whitespace".  I'd expect it to be referred to as such.

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/91fd28b61badff20e75856f09fc2eb84bb537570
Bug 1258794 - Pre: Add GenericWhitespace and fix single issue. r=nalexander

https://hg.mozilla.org/integration/fx-team/rev/07bbdd454906d6e1bfc5f812809a18df5d59c0cc
Bug 1258794 - Add trailing whitespace checkstyle check & fix issues. r=nalexander

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/91fd28b61bad
https://hg.mozilla.org/mozilla-central/rev/07bbdd454906