Closed
Bug 1258807
Opened 8 years ago
Closed 8 years ago
Conditional breakpoint is gone
Categories
(DevTools :: Debugger, defect, P1)
DevTools
Debugger
Tracking
(firefox45 affected, firefox46 affected, firefox47 affected, firefox48 fixed, firefox-esr45 affected)
RESOLVED
FIXED
Firefox 48
People
(Reporter: magicp.jp, Assigned: jlong)
Details
Attachments
(2 files)
725.38 KB,
video/mp4
|
Details | |
10.83 KB,
patch
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:48.0) Gecko/20100101 Firefox/48.0 Build ID: 20160322030417 Steps to reproduce: 1. Start Nightly 2. Go to any sites (e.g. about:home) 3. Open Debugger 4. Select any source items 5. Add a conditional breakpoint with expression 6. Disable (check-off) the conditional breakpoint (not remove) 7. Enable (check-on) the conditional breakpoint remain opening the expression panel Actual results: [Aurora, Nightly] The conditional breakpoint is gone from side panel. [Firefox 45.0.1, 46.0b2] The conditional breakpoint on line number is gone. And also cannot select its source item. Expected results: Conditional breakpoint check-on works correctly.
Has STR: --- → yes
status-firefox45:
--- → affected
status-firefox46:
--- → affected
status-firefox47:
--- → affected
status-firefox48:
--- → affected
status-firefox-esr45:
--- → affected
Component: Untriaged → Developer Tools: Debugger
OS: Unspecified → All
Hardware: Unspecified → All
Version: Trunk → unspecified
Comment 1•8 years ago
|
||
James, you recently made a change in how we enable/disable conditional breakpoints. Could this be a regression? In any case, this should be fixed asap. Marking as p1.
Flags: needinfo?(jlong)
Priority: -- → P1
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → jlong
Flags: needinfo?(jlong)
Assignee | ||
Comment 2•8 years ago
|
||
Thanks for these excellent bug reports. The problem was updating a breakpoint's condition when it's disabled; this patch fixes that. The rogue breakpoint in the editor was because of a bug introduced in the patch that colors conditional breakpoints differently. I've expanded the test cases to handle this.
Assignee | ||
Comment 3•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9283cce7882f
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/24b5fb250c49
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•