1258809 - Fix and re-enable netmonitor devtool tests

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P4)

Comment 1

[Christoph Kerschbaumer [:ckerschb]]

Attachment: bug_1258809_fix_and_reenable_netmonitor_tests.patch

Victor, as discussed here is a starting point of where potential problems are with the tests. Here is also the TRY push from Bug 1243586:
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=53996f79376d

Please keep in mind that I got different results on different platforms - JFYI.

Thanks!

Comment 2

[Christoph Kerschbaumer [:ckerschb]]

+++ b/devtools/client/netmonitor/test/browser.ini
@@ -107,17 +107,19 @@ skip-if = e10s # Bug 1091612
 [browser_net_security-state.js]
 [browser_net_security-tab-deselect.js]
 [browser_net_security-tab-visibility.js]
 [browser_net_security-warnings.js]
 [browser_net_send-beacon.js]
 [browser_net_send-beacon-other-tab.js]
 [browser_net_simple-init.js]
 [browser_net_simple-request-data.js]
+skip-if = true # Bug 1258809
 [browser_net_simple-request-details.js]
+skip-if = true # Bug 1258809
 [browser_net_simple-request.js]

Comment 3

[Victor Porof [:vporof][:vp]]

Can't work on this right now, busy with Tofino.

Comment 4

[Dhyey Thakore [:dhyey35]]

Can I take this issue while writing test for https://bugzilla.mozilla.org/show_bug.cgi?id=1003153 as nchevobbe suggested in slack ?

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Done, thanks for the help.

Honza

Comment 6

[Dhyey Thakore [:dhyey35]]

Attachment: Bug 1258809 - fix and re-enable netmonitor devtools details UI test, r=Honza

Comment 7

[Dhyey Thakore [:dhyey35]]

Honza I have put some FOR REVIEWER comments in the code where I think code needs some changes.

Comment 8

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to dhyey35 from comment #7)

Honza I have put some FOR REVIEWER comments in the code where I think code needs some changes.
I posted comments in Phab

Thanks!
Honza

Comment 9

[Dhyey Thakore [:dhyey35]]

I have updated the code according to the comments.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/454b81601594
fix and re-enable netmonitor devtools details UI test, r=Honza

Comment 11

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/454b81601594