125881 - nsIProperties.Has() misbehaves for empty values

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Ben Bucksch (:BenB)]

If you have a property with 0 as value (because you don't need it, just the
existance of the property), Has returns false. This is broken.

From old code:
// XXX this is bogus because it doesn't distinguish between properties
// defined with a value NULL, and undefined properties, but we'll fix
// it later if it becomes a problem

Would've been nice, if you told me in the interface :). (I was hunting that bug
in my own code.)

Will attach patch. Please review.

Comment 1

[Ben Bucksch (:BenB)]

Attachment: Proposed fix, version 1

Comment 2

[Doug Turner (:dougt)]

Comment on attachment 69846 [details] [diff] [review]
Proposed fix, version 1

r=dougt

Comment 3

[John Bandhauer]

Comment on attachment 69846 [details] [diff] [review]
Proposed fix, version 1

sr=jband

Comment 4

[Ben Bucksch (:BenB)]

checked in. Thanks for the fast reviews! :-)

Comment 5

[Jerome Lacoste]

to reopen cf bug 138138.

Comment 6

[Jerome Lacoste]

I mean 'caused regression' not 'to reopen'. Can stay fixed as the other bug was
created.

NB: 
> "Thanks for the fast reviews! :-)"  

Too fast? ;) 

Comment 7

[Ben Bucksch (:BenB)]

I don't think so, see the other bug.