Closed Bug 1258820 Opened 4 years ago Closed 4 years ago

Mousewheel on menulist scrolls content area

Categories

(Core :: DOM: Events, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: enndeakin, Assigned: Arata)

Details

Attachments

(1 file, 1 obsolete file)

See bug 1258355 for steps, but use the mousewheel while hovering over the popup area. This affects all platforms.

The issue is that the code that determines the location of the mousewheel event checks up the frame hierarchy looking for a scrollable frame. It should break out when a menupopup frame is encountered.

There seems to be several places that look to handle mousewheel events (esm, presshell, nsLayoutUtils::GetNearestScrollableFrame) so I'm not sure which is correct? masayuki, where I would I look for this?
Flags: needinfo?(masayuki)
Without looking too much this, I think EventStateManager::ComputeScrollTarget might be a good place to fix this.
Yeah, probably, we should stop climbing up the frame tree when we meet nsMenuPopupFrame.
Flags: needinfo?(masayuki)
# this might be useful for hacking event in Mozilla Japan. If nobody won't fix this bug at the event, I'll take this.
Attached patch patch (obsolete) — Splinter Review
Attachment #8735055 - Flags: review?(masayuki)
Assignee: nobody → old.river.new
EventStateManager::ComputeScrollTarget() should stop looking for scrollable frame if it meets nsMenuPopupFrame because the user must not want to scroll outside the popup.

Review commit: https://reviewboard.mozilla.org/r/42559/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/42559/
Attachment #8735065 - Flags: review?(masayuki)
Attachment #8735055 - Attachment is obsolete: true
Attachment #8735055 - Flags: review?(masayuki)
Comment on attachment 8735065 [details]
MozReview Request: Bug 1258820 - making root scrollable element not scroll if mouse wheel is used on xul dropdown r?masayuki

https://reviewboard.mozilla.org/r/42559/#review39063

Thank you very much, Furukawa-san, I'll land this patch after I check the patch doesn't have any trouble on tryserver.
Attachment #8735065 - Flags: review?(masayuki) → review+
https://hg.mozilla.org/mozilla-central/rev/d05645511500
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Duplicate of this bug: 1226915
You need to log in before you can comment on or make changes to this bug.