Closed
Bug 1258847
Opened 8 years ago
Closed 8 years ago
Set PTHREAD_MUTEX_ERRORCHECK for js::Mutex in debug builds
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: fitzgen, Assigned: fitzgen)
Details
Attachments
(1 file, 1 obsolete file)
1.12 KB,
patch
|
fitzgen
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8733570 -
Flags: review?(sphink)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•8 years ago
|
||
Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3887265428b3
Comment 3•8 years ago
|
||
Comment on attachment 8733570 [details] [diff] [review] Set PTHREAD_MUTEX_ERRORCHECK for js::Mutex in debug builds Review of attachment 8733570 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/threading/posix/Mutex.cpp @@ +18,5 @@ > if (!platformData_) > oom.crash("js::Mutex::Mutex"); > > + int r = 0; > + pthread_mutexattr_t* attrp = NULL; I think we're supposed to use nullptr now. @@ +24,5 @@ > +#ifdef DEBUG > + pthread_mutexattr_t attr; > + > + r = pthread_mutexattr_init(&attr); > + MOZ_ASSERT(r == 0); MOZ_ALWAYS_TRUE(pthread_mutexattr_init(&attr)); and the same for the rest.
Attachment #8733570 -
Flags: review?(sphink) → review+
Assignee | ||
Updated•8 years ago
|
Attachment #8733570 -
Attachment is obsolete: true
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/038c00218cf4
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•