Closed Bug 1258860 Opened 8 years ago Closed 8 years ago

Make test_basic_form_autocomplete.html work in e10s

Categories

(Toolkit :: Password Manager, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
e10s + ---
firefox48 --- fixed

People

(Reporter: MattN, Assigned: MattN)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

This will follow the approach as bug 1258607
Depends on: 1258921
Comment on attachment 8733700 [details]
MozReview Request: Bug 1258860 - Make test_basic_form_autocomplete.html work in e10s. r=dolske

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/41867/diff/1-2/
Attachment #8733700 - Attachment description: MozReview Request: Bug 1258860 - WIP: Make test_basic_form_autocomplete.html work in e10s. → MozReview Request: Bug 1258860 - Make test_basic_form_autocomplete.html work in e10s. r=dolske
Attachment #8733700 - Flags: review?(dolske)
Blocks: 1262301
Comment on attachment 8733700 [details]
MozReview Request: Bug 1258860 - Make test_basic_form_autocomplete.html work in e10s. r=dolske

https://reviewboard.mozilla.org/r/41867/#review42421

::: toolkit/components/passwordmgr/test/pwmgr_common.js:301
(Diff revision 2)
> +  });
> +}
> +
> +function countLogins(chromeScript, formOrigin, submitOrigin, httpRealm) {
> +  return chromeScript.sendSyncMessage("countLogins", {formOrigin, submitOrigin, httpRealm})[0][0];
> +}

Seems like it would be helpful to group these together into a single object/module that handles proxying all the pwmgr APIs (or at least the ones we need)...

EG, in code where you'd previously call Services.logins.foo() you could call ProxyLogins.foo().
Attachment #8733700 - Flags: review?(dolske) → review+
(In reply to Justin Dolske [:Dolske] from comment #3)
> Seems like it would be helpful to group these together into a single
> object/module that handles proxying all the pwmgr APIs (or at least the ones
> we need)...
> 
> EG, in code where you'd previously call Services.logins.foo() you could call
> ProxyLogins.foo().

I'll keep this in mind for the future. I think we won't end up needing this for the e10s conversions as it's mostly done but it could be useful for the future.
https://hg.mozilla.org/mozilla-central/rev/b75748217b75
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.