Closed Bug 1258865 Opened 4 years ago Closed 4 years ago

Land version 1.2.2 of the Loop system add-on in mozilla-central

Categories

(Hello (Loop) :: Client, defect, P1)

defect

Tracking

(firefox46 verified, firefox47 fixed, firefox48 fixed)

VERIFIED FIXED
mozilla48
Tracking Status
firefox46 --- verified
firefox47 --- fixed
firefox48 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

(Whiteboard: [btpp-fix-now])

Attachments

(5 files)

This is the next update for Loop. Top-level changes:

- Click indications during sharing to highlight where a person is pointing/clicking
- Improvements to sharing: the invitation to copy a url now appears in the panel before the separate window opens
- Editing the room name from the panel
https://hg.mozilla.org/integration/fx-team/rev/40b54454f437fe04c74ce606a573c5f065aeb655
Bug 1258865 - Land version 1.2.2 of the Loop system add-on in mozilla-central - locale updates. rs=Standard8 for already reviewed code.

https://hg.mozilla.org/integration/fx-team/rev/adc8f032dfbf951040608b5ef38a53f6e16725dd
Bug 1258865 - Land version 1.2.2 of the Loop system add-on in mozilla-central - vendor updates. rs=Standard8 for already reviewed code.

https://hg.mozilla.org/integration/fx-team/rev/cc5442d3b8bdd6c182d8da4993e0ad3d2e6a8fed
Bug 1258865 - Land version 1.2.2 of the Loop system add-on in mozilla-central - code updates. rs=Standard8 for already reviewed code.
Rank: 1
Attachment #8734357 - Attachment description: Aurora version of code updates → Aurora/Beta version of code updates
Comment on attachment 8733605 [details] [diff] [review]
Land version 1.2.2 of the Loop system add-on in mozilla-central - locale updates. rs=Standard8 for already reviewed code.

Approval Request Comment
[Feature/regressing bug #]: Firefox Hello 1.2.x release
[User impact if declined]: See comment 0. In addition, this release enables e10s functionality for Hello users on Firefox 47 and later. It will remain "disabled" for users of 46.
[Describe test coverage new/current, TreeHerder]: N/A String import from locales only.
[Risks and why]: Low, string changes
[String/UUID change made/needed]: None
Attachment #8733605 - Flags: approval-mozilla-aurora?
Comment on attachment 8733605 [details] [diff] [review]
Land version 1.2.2 of the Loop system add-on in mozilla-central - locale updates. rs=Standard8 for already reviewed code.

Approval Request Comment

- Please see previous comment.
Attachment #8733605 - Flags: approval-mozilla-beta?
Comment on attachment 8733606 [details] [diff] [review]
Land version 1.2.2 of the Loop system add-on in mozilla-central - vendor updates. rs=Standard8 for already reviewed code.

Approval Request Comment
[Feature/regressing bug #]: Firefox Hello 1.2.x release
[User impact if declined]: See comment 0. In addition, this release enables e10s functionality for Hello users on Firefox 47 and later. It will remain "disabled" for users of 46.
[Describe test coverage new/current, TreeHerder]: This is updates to our vendor libaries which are well used by many projects. Our existing test coverage covers the parts we use of these libraries.
[Risks and why]: Low, vendor library updates only.
[String/UUID change made/needed]: None
Attachment #8733606 - Flags: approval-mozilla-beta?
Attachment #8733606 - Flags: approval-mozilla-aurora?
Comment on attachment 8734357 [details] [diff] [review]
Aurora/Beta version of code updates

Approval Request Comment
[Feature/regressing bug #]: Firefox Hello 1.2.x release
[User impact if declined]: See comment 0. In addition, this release enables e10s functionality for Hello users on Firefox 47 and later. It will remain "disabled" for users of 46.
[Describe test coverage new/current, TreeHerder]: Landed in m-c, tested amongst the team for a couple of weeks now. We have unit tests and integration 
[Risks and why]: For beta: Low, self-contained to Hello most of these updates have been in our tree for a while. For aurora: Medium as we're turning on the e10s portion of Hello, but we want to do this now, as 47 is likely to roll out e10s users, and we need to get testing as we think we've fixed almost all the issues.
[String/UUID change made/needed]: None
Attachment #8734357 - Flags: approval-mozilla-beta?
Attachment #8734357 - Flags: approval-mozilla-aurora?
Blocks: 1256362
Note: we also need bug 1254102 on aurora to fix various issues with Firefox crashing in e10s mode when we're tab sharing.
Depends on: 1254102
This should also fix an issue with private browsing (bug 1256362) which goes all the way to release.
Comment on attachment 8733605 [details] [diff] [review]
Land version 1.2.2 of the Loop system add-on in mozilla-central - locale updates. rs=Standard8 for already reviewed code.

Hello system add-on update v1.2.2, Aurora47+
Attachment #8733605 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #8733606 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #8734357 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment on attachment 8734357 [details] [diff] [review]
Aurora/Beta version of code updates

OK for beta uplift. This could make a beta 6 build 2 if we do one. If not, beta 7 build on Thursday and release on Friday.
Attachment #8734357 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #8733605 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #8733606 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
This fixes the xpcshell test issue on beta - there was some syntax that it didn't like for some reason.

To fix the mochitest issue, we need bug 1245486 for which I've requested approval on.
Flags: needinfo?(standard8)
Wes or tomcat, can you land this again on beta this morning? Thanks.
Flags: needinfo?(wkocher)
Flags: needinfo?(cbook)
(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #19)
> Wes or tomcat, can you land this again on beta this morning? Thanks.

np, done as  https://hg.mozilla.org/releases/mozilla-beta/rev/e5b3ef0d7e32
Flags: needinfo?(wkocher)
Flags: needinfo?(cbook)
We finished Smoke testing on Firefox 46 beta 7 with 1.2.2 version of Hello add-on, we encountered 4 new issues (bugzilla query https://goo.gl/lK2255), but only one of them seems major (bug 1261843). 
Other than that, nothing major was found.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Depends on: 1256357
You need to log in before you can comment on or make changes to this bug.