1258867 - Support taking windows out of fullscreen mode on OS-X

Status: NEW

(WebExtensions :: Frontend, defect, P3)

Description

[Kris Maglione [:kmag]]

Currently, it's possible to put windows into fullscreen mode on OS-X, but not to take them out.

This currently causes problems with our window sizing tests, since we can't resize fullscreen windows, and sometimes new windows unexpectedly open in fullscreen mode, which we have no ability to override.

Comment 1

[Andy McKay]

spohl, it was suggested you might be able to help out on this? I think (:kmag can clarify) that we are having problems taking windows out of full screen mode on OS X.

Comment 2

[Stephen A Pohl [:spohl] (OOO until 1/26)]

More info would definitely be helpful here. Are these tests checked into the tree somewhere? Is the issue believed to be in platform code and why?

Comment 3

[Kris Maglione [:kmag]]

Sorry, I'll need to wait until I'm home and have a Mac in front of me to confirm all of the details, but the basic problem is that (at least on Sierra and later) once windows are put in fullscreen mode (in the OS sense, rather than the chrome hidden sense), we never seem to take them out. It seems that these are the only places where we toggle fullscreen mode, and we only toggle it one way:

http://searchfox.org/mozilla-central/rev/72fe012899a1b27d34838ab463ad1ae5b116d76b/widget/cocoa/nsCocoaWindow.mm#1250-1284
http://searchfox.org/mozilla-central/rev/72fe012899a1b27d34838ab463ad1ae5b116d76b/widget/cocoa/nsCocoaWindow.mm#1524-1529

After which these tests fail if they need a window to be in normal mode, either so they can be resized or so we can test the state change functions:

http://searchfox.org/mozilla-central/source/browser/components/extensions/test/browser/browser-common.ini#137-138,143-146

Comment 4

[Stephen A Pohl [:spohl] (OOO until 1/26)]

Sorry about the delay! I haven't had time to look into this in detail yet, but I see that Markus has at least reviewed some code related to fullscreen. Markus, do you have any thoughts here? If not, I will have to come back to this when my plate clears.

Comment 5

[Xidorn Quan [:xidorn] UTC+10]

Firstly I wonder in which condition can a window opens in fullscreen... I don't expect that to happen at all after bug 1137009.

Anyway, I think the way to take windows out of fullscreen mode is to set window.fullScreen to false. That is how it works in Firefox's own Full Screen button. I'm not completely sure whether setting size mode works. It probably should, so if it doesn't, that might be a bug worth filing I guess.