Closed
Bug 1258924
Opened 8 years ago
Closed 8 years ago
Reorder DOMIfaceAndProtoJSClass fields to reduce padding
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
Details
Attachments
(1 file)
5.18 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
DOMIfaceAndProtoJSClass is not optimally packed.
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8733672 -
Flags: review?(bzbarsky)
Comment 2•8 years ago
|
||
Comment on attachment 8733672 [details] [diff] [review] Reorder DOMIfaceAndProtoJSClass fields to reduce padding > + enumstr = comment + 'enum %s : uint16_t\n{\n%s\n};\n' % (enumName, ',\n'.join(entries)) I was a bit worried about the enums overflowing here as we add more things to the web platform, but looks like that results in a compile error, right? r=me
Attachment #8733672 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 3•8 years ago
|
||
(In reply to Boris Zbarsky [:bz] from comment #2) > > > + enumstr = comment + 'enum %s : uint16_t\n{\n%s\n};\n' % (enumName, ',\n'.join(entries)) > > I was a bit worried about the enums overflowing here as we add more things > to the web platform, but looks like that results in a compile error, right? Yes. GCC says something like "error: enumerator value <X> is outside the range of underlying type". And we currently have a maximum value of less than 900, so there's plenty of room to grow :)
Assignee | ||
Comment 4•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/edba1116e87e703f360794e5749279c04a09a3a4 Bug 1258924 - Reorder DOMIfaceAndProtoJSClass fields to reduce padding. r=bz.
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/edba1116e87e
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•