Closed Bug 1258966 Opened 8 years ago Closed 8 years ago

Remove unnecessary null-checks of MediaDecoderStateMachine::mReader

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

Details

Attachments

(1 file)

mReader is a const member which is never null.
Assignee: nobody → jwwang
Comment on attachment 8733763 [details]
MozReview Request: Bug 1258966 - Remove unnecessary null-checks of MediaDecoderStateMachine::mReader. r=bechen.

https://reviewboard.mozilla.org/r/41945/#review38913
Attachment #8733763 - Flags: review?(bechen) → review+
Thanks!
https://hg.mozilla.org/mozilla-central/rev/0bdd199c0911
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
An option for next time would be to use mozilla::NotNull here. That makes the non-nullness more obvious :)
You need to log in before you can comment on or make changes to this bug.