Closed
Bug 1258981
Opened 8 years ago
Closed 8 years ago
sources-view.js: The "popupshown" listener is incorrectly removed
Categories
(DevTools :: Debugger, defect, P2)
DevTools
Debugger
Tracking
(firefox48 fixed)
RESOLVED
FIXED
Firefox 48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: jsnajdr, Assigned: jsnajdr)
Details
Attachments
(1 file)
1.50 KB,
patch
|
jlong
:
review+
|
Details | Diff | Splinter Review |
In devtools/client/debugger/content/view/sources-view.js:149, in the SourcesView.destroy method, a listener for "popupshown" is incorrectly removed: this._cbPanel.removeEventListener("popupshowing", this._onConditionalPopupShown, false); The event name should be "popupshown", of course. Discovered accidentally when grepping the sources for examples how to work with popup menus.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → jsnajdr
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8733815 -
Flags: review?(jlong)
Comment 2•8 years ago
|
||
Comment on attachment 8733815 [details] [diff] [review] sources-view.js: The popupshown listener is incorrectly removed Review of attachment 8733815 [details] [diff] [review]: ----------------------------------------------------------------- Thanks a lot!
Attachment #8733815 -
Flags: review?(jlong) → review+
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 3•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f8ffb7c3aa5d
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Updated•8 years ago
|
Priority: -- → P2
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/188898ff25c1
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•